feat(accessibility): forward importantForAccessibility prop#2709
Open
vicprz wants to merge 4 commits into
Open
feat(accessibility): forward importantForAccessibility prop#2709vicprz wants to merge 4 commits into
vicprz wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I have been focusing heavily on improving the accessibility of my application and encountered a few blocking issues on Android with the current implementation.
1. Focusable BottomSheetContent
By default, the entire
BottomSheetContentwas being treated as a single focusable element. This prevented screen readers from navigating inside the container to interact with individual components. While passingaccessible={false}toBottomSheetModalresolved the issue on iOS, Android requiresimportantForAccessibility="no". This prop was not previously being forwarded by the library, so this PR adds that support.2. Focusable Backdrop
I needed to prevent the backdrop from being focusable by screen readers since I have an explicit "Close" button inside the bottom sheet. Similar to the issue above,
accessible={false}worked perfectly for iOS, but Android requiredimportantForAccessibility="no". This PR brings that property to the backdrop component.3. Consistency across components
For the sake of consistency, I also added
importantForAccessibilityprop forwarding toBottomSheetHandle, as it was the last remaining place whereNullableAccessibilityPropswere being utilized without it.