Fix hidden and expired items in recommendation results#1192
Fix hidden and expired items in recommendation results#1192eyupcanakman wants to merge 2 commits intogorse-io:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1192 +/- ##
==========================================
+ Coverage 72.72% 72.74% +0.01%
==========================================
Files 88 88
Lines 16258 16333 +75
==========================================
+ Hits 11824 11881 +57
- Misses 3233 3242 +9
- Partials 1201 1210 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
#1206 now pushes ItemTTL into the storage query and #1197 keeps hidden items out of the item-to-item index. The remaining paths (Recommend, Collaborative, NonPersonalized, UserToUser, External) still aren't filtered. Want me to rebase and narrow this to those, or close it and file smaller follow-ups that match your approach? |
Thank you for your reply. New BatchGetItem could be used for filtering now. You could close this PR if rebase is more hard than open a new one. |
|
Closing. I'll open a narrower follow-up using the new |
Fixes #764
Summary
Recommendation results could still include hidden items and items older than
item_ttl.Filter cached and fallback recommendation results against current item metadata, and keep scanning past filtered entries so valid items still fill the response. Keep cache-only IDs without item rows unchanged.
Testing
go test ./logics ./server ./worker -count=1go test ./... -run '^$' -count=1