fix: initialize nil patterns map in extractPlaceID to prevent panic#261
Merged
Merged
Conversation
The patterns map was declared but never initialized before being written to in the sync.Once block, causing a nil map assignment panic at runtime. Added unit tests for extractPlaceID covering various URL formats.
aurbina83
force-pushed
the
bugfix/nil-map-panic-extractPlaceID
branch
from
7aa42e8 to
3623ea4
Compare
Owner
|
@aurbina83 thanks for you contribution. I will fix linter and merge asap |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fix
The
patternsmap inextractPlaceID(gmaps/reviews.go) was declared but never initialized before being written to inside thesync.Onceblock. This caused a nil map assignment panic at runtime whenextractPlaceIDwas called for the first time.Fix
Added
patterns = make(map[string]*regexp.Regexp)before the loop that populates the map.Tests
Added
gmaps/reviews_test.gowith unit tests forextractPlaceIDcovering:place_idquery parameter format