Skip to content

Commit 053efdb

Browse files
committed
fix
1 parent 852c400 commit 053efdb

3 files changed

Lines changed: 10 additions & 7 deletions

File tree

kernel/src/engine/default/filesystem.rs

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -309,12 +309,10 @@ impl<E: TaskExecutor> StorageHandler for ObjectStoreStorageHandler<E> {
309309
Ok(())
310310
});
311311

312-
if result.is_ok() {
313-
if let Some(ref r) = reporter {
314-
r.report(MetricEvent::StorageCopyCompleted {
315-
duration: timer.elapsed(),
316-
});
317-
}
312+
if let Some(ref r) = reporter {
313+
r.report(MetricEvent::StorageCopyCompleted {
314+
duration: timer.elapsed(),
315+
});
318316
}
319317

320318
result

kernel/src/metrics/mod.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
//! use std::sync::Arc;
1515
//! use delta_kernel::metrics::{MetricsReporter, MetricEvent};
1616
//!
17+
//! #[derive(Debug)]
1718
//! struct LoggingReporter;
1819
//!
1920
//! impl MetricsReporter for LoggingReporter {
@@ -45,6 +46,7 @@
4546
//! use std::sync::Arc;
4647
//! use delta_kernel::metrics::{MetricsReporter, MetricEvent};
4748
//!
49+
//! #[derive(Debug)]
4850
//! struct CompositeReporter {
4951
//! reporters: Vec<Arc<dyn MetricsReporter>>,
5052
//! }

kernel/src/snapshot/builder.rs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,10 @@ mod tests {
195195
) {
196196
let table_root = Url::parse("memory:///test_table").unwrap();
197197
let store = Arc::new(InMemory::new());
198-
let engine = Arc::new(DefaultEngine::new(store.clone(), Arc::new(TokioBackgroundExecutor::new())));
198+
let engine = Arc::new(DefaultEngine::new(
199+
store.clone(),
200+
Arc::new(TokioBackgroundExecutor::new()),
201+
));
199202
(engine, store, table_root)
200203
}
201204

0 commit comments

Comments
 (0)