Skip to content

Commit 16f3d5c

Browse files
committed
revert: revert LastCheckpointHint internal-api exposure
Reverts 4dcf805 and 4b70a26. Will reland with a smaller scope: only `path()` is needed externally. Co-authored-by: Isaac
1 parent 7af375f commit 16f3d5c

1 file changed

Lines changed: 9 additions & 10 deletions

File tree

kernel/src/last_checkpoint_hint.rs

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -40,26 +40,26 @@ pub(crate) struct LastCheckpointHintSummary {
4040
#[internal_api]
4141
pub(crate) struct LastCheckpointHint {
4242
/// The version of the table when the last checkpoint was made.
43+
#[allow(unreachable_pub)] // used by acceptance tests (TODO make an fn accessor?)
4344
pub version: Version,
4445
/// The number of actions that are stored in the checkpoint.
45-
pub size: i64,
46+
pub(crate) size: i64,
4647
/// The number of fragments if the last checkpoint was written in multiple parts.
47-
pub parts: Option<usize>,
48+
pub(crate) parts: Option<usize>,
4849
/// The number of bytes of the checkpoint.
49-
pub size_in_bytes: Option<i64>,
50+
pub(crate) size_in_bytes: Option<i64>,
5051
/// The number of AddFile actions in the checkpoint.
51-
pub num_of_add_files: Option<i64>,
52+
pub(crate) num_of_add_files: Option<i64>,
5253
/// The schema of the checkpoint file.
53-
pub checkpoint_schema: Option<SchemaRef>,
54+
pub(crate) checkpoint_schema: Option<SchemaRef>,
5455
/// The checksum of the last checkpoint JSON.
55-
pub checksum: Option<String>,
56+
pub(crate) checksum: Option<String>,
5657
/// Additional metadata about the last checkpoint.
57-
pub tags: Option<HashMap<String, String>>,
58+
pub(crate) tags: Option<HashMap<String, String>>,
5859
}
5960

6061
impl LastCheckpointHint {
61-
/// Returns the path of the `_last_checkpoint` file given the log root of a table.
62-
#[internal_api]
62+
// Returns the path the last checkpoint file given the log root of a table.
6363
pub(crate) fn path(log_root: &Url) -> DeltaResult<Url> {
6464
Ok(log_root.join(LAST_CHECKPOINT_FILE_NAME)?)
6565
}
@@ -72,7 +72,6 @@ impl LastCheckpointHint {
7272
/// are assumed to cause failure.
7373
// TODO(#1047): weird that we propagate FileNotFound as part of the iterator instead of top-
7474
// level result coming from storage.read_files
75-
#[internal_api]
7675
#[instrument(name = "last_checkpoint.read", skip_all, err)]
7776
pub(crate) fn try_read(
7877
storage: &dyn StorageHandler,

0 commit comments

Comments
 (0)