You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
test: consolidate write tests into single [[test]] binary (delta-io#2472)
## What changes are proposed in this pull request?
Collapses the 15 `kernel/tests/write_*.rs` files (split out in delta-io#2460)
into a single integration test binary declared via `[[test]]` in
`kernel/Cargo.toml`. Topic files move under `kernel/tests/write/` as
modules of `tests/write/main.rs`.
Test discovery and filtering are unchanged from a user POV: `cargo
nextest run --test write` runs the whole binary, `cargo nextest run
write::stats::` filters by topic.
`cargo test --test write_stats`-style compile pruning of one topic is
lost
## How was this change tested?
Measured locally, after `touch kernel/src/lib.rs`:
| | Binaries | `cargo build --tests -p delta_kernel --all-features` |
|---|---|---|
| before | 32 | 45.82s |
| after | 18 | 35.04s |
|`table-without-dv-small`| data/ |`value: long`| v1/v2 || 10 rows, all visible. Companion to table-with-dv-small. |`dv.rs::test_table_scan(without_dv)`, `transaction/mod.rs::setup_non_dv_table/create_existing_table_txn/test_commit_io_error_returns_retryable_transaction`, `sequential_phase.rs::test_sequential_v2_with_commits_only/test_sequential_finish_before_exhaustion_error`, `parallel_phase.rs` tests, `scan/tests.rs::test_scan_metadata_paths/test_scan_metadata/test_scan_metadata_from_same_version`|
14
14
|`with-short-dv`| data/ |`id: long, value: string, timestamp: timestamp, rand: double`| v3/v7 | r:`deletionVectors` w:`deletionVectors`| 2 files x 5 rows. First file has inline DV (`storageType="u"`) deleting 3 rows. |`read.rs::short_dv`|
15
15
|`dv-partitioned-with-checkpoint`| golden_data/ |`value: int, part: int` partitioned by `part`| v3/v7 | r:`deletionVectors` w:`deletionVectors`| DVs on a partitioned table with a checkpoint |`golden_tables.rs::golden_test!`|
@@ -41,9 +41,9 @@ Test tables organized by feature area. Tables live in two locations:
|`with_checkpoint_no_last_checkpoint`| data/ |`letter: string, int: long, date: date`| v1/v2 |`checkpointInterval=2`| Checkpoint at v2 but missing `_last_checkpoint` hint file |`snapshot.rs::test_read_table_with_checkpoint`, `scan/tests.rs::test_scan_with_checkpoint`, `sequential_phase.rs::test_sequential_checkpoint_no_commits`, `checkpoint_manifest.rs` tests, `sync/parquet.rs` test, `default/parquet.rs` test |
55
-
|`external-table-different-nullability`| data/ |`i: int`| v1/v2 |`checkpointInterval=2`| Parquet files have different nullability than Delta schema; includes checkpoint |`write_clustered.rs::test_checkpoint_non_kernel_written_table`|
55
+
|`external-table-different-nullability`| data/ |`i: int`| v1/v2 |`checkpointInterval=2`| Parquet files have different nullability than Delta schema; includes checkpoint |`write::clustered::test_checkpoint_non_kernel_written_table`|
0 commit comments