better

Author: gotocoding-DB

ffi/src/lib.rs

@@ -565,7 +565,6 @@ fn get_default_engine_impl(
         &url,
         options,
         Arc::new(TokioBackgroundExecutor::new()),
-        None,
     );
     Ok(engine_to_handle(Arc::new(engine?), allocate_error))
 }

kernel/examples/common/src/lib.rs

@@ -161,14 +161,13 @@ pub fn get_engine(
         Ok(DefaultEngine::new(
             store,
             Arc::new(TokioBackgroundExecutor::new()),
-            None,
         ))
     } else if !args.option.is_empty() {
         let opts = args.option.iter().map(|option| {
             let parts: Vec<&str> = option.split("=").collect();
             (parts[0].to_ascii_lowercase(), parts[1])
         });
-        DefaultEngine::try_new(url, opts, Arc::new(TokioBackgroundExecutor::new()), None)
+        DefaultEngine::try_new(url, opts, Arc::new(TokioBackgroundExecutor::new()))
     } else {
         let mut options = if let Some(ref region) = args.region {
             HashMap::from([("region", region.clone())])
@@ -178,7 +177,7 @@ pub fn get_engine(
         if args.public {
             options.insert("skip_signature", "true".to_string());
         }
-        DefaultEngine::try_new(url, options, Arc::new(TokioBackgroundExecutor::new()), None)
+        DefaultEngine::try_new(url, options, Arc::new(TokioBackgroundExecutor::new()))
     }
 }
 

kernel/examples/write-table/src/main.rs

@@ -80,7 +80,6 @@ async fn try_main() -> DeltaResult<()> {
         &url,
         HashMap::<String, String>::new(),
         Arc::new(TokioBackgroundExecutor::new()),
-        None,
     )?;
 
     // Create or get the table

kernel/src/engine/default/mod.rs

@@ -25,6 +25,7 @@ use crate::transaction::WriteContext;
 use crate::{
     DeltaResult, Engine, EngineData, EvaluationHandler, JsonHandler, ParquetHandler, StorageHandler,
 };
+use delta_kernel_derive::internal_api;
 
 pub mod executor;
 pub mod file_stream;
@@ -51,11 +52,31 @@ impl<E: TaskExecutor> DefaultEngine<E> {
     /// - `table_root`: The URL of the table within storage.
     /// - `options`: key/value pairs of options to pass to the object store.
     /// - `task_executor`: Used to spawn async IO tasks. See [executor::TaskExecutor].
-    /// - `reporter`: Optional metrics reporter for tracking operation metrics.
     pub fn try_new<K, V>(
         table_root: &Url,
         options: impl IntoIterator<Item = (K, V)>,
         task_executor: Arc<E>,
+    ) -> DeltaResult<Self>
+    where
+        K: AsRef<str>,
+        V: Into<String>,
+    {
+        Self::try_new_with_metrics(table_root, options, task_executor, None)
+    }
+
+    /// Create a new [`DefaultEngine`] instance with metrics reporting
+    ///
+    /// # Parameters
+    ///
+    /// - `table_root`: The URL of the table within storage.
+    /// - `options`: key/value pairs of options to pass to the object store.
+    /// - `task_executor`: Used to spawn async IO tasks. See [executor::TaskExecutor].
+    /// - `reporter`: Optional metrics reporter for tracking operation metrics.
+    #[internal_api]
+    pub(crate) fn try_new_with_metrics<K, V>(
+        table_root: &Url,
+        options: impl IntoIterator<Item = (K, V)>,
+        task_executor: Arc<E>,
         reporter: Option<Arc<dyn crate::metrics::MetricsReporter>>,
     ) -> DeltaResult<Self>
     where
@@ -64,7 +85,7 @@ impl<E: TaskExecutor> DefaultEngine<E> {
     {
         // table root is the path of the table in the ObjectStore
         let (object_store, _table_root) = parse_url_opts(table_root, options)?;
-        Ok(Self::new(Arc::new(object_store), task_executor, reporter))
+        Ok(Self::new_with_metrics(Arc::new(object_store), task_executor, reporter))
     }
 
     /// Create a new [`DefaultEngine`] instance
@@ -73,10 +94,24 @@ impl<E: TaskExecutor> DefaultEngine<E> {
     ///
     /// - `object_store`: The object store to use.
     /// - `task_executor`: Used to spawn async IO tasks. See [executor::TaskExecutor].
-    /// - `reporter`: Optional metrics reporter for tracking operation metrics.
     pub fn new(
         object_store: Arc<DynObjectStore>,
         task_executor: Arc<E>,
+    ) -> Self {
+        Self::new_with_metrics(object_store, task_executor, None)
+    }
+
+    /// Create a new [`DefaultEngine`] instance with metrics reporting
+    ///
+    /// # Parameters
+    ///
+    /// - `object_store`: The object store to use.
+    /// - `task_executor`: Used to spawn async IO tasks. See [executor::TaskExecutor].
+    /// - `reporter`: Optional metrics reporter for tracking operation metrics.
+    #[internal_api]
+    pub(crate) fn new_with_metrics(
+        object_store: Arc<DynObjectStore>,
+        task_executor: Arc<E>,
         reporter: Option<Arc<dyn crate::metrics::MetricsReporter>>,
     ) -> Self {
         Self {
@@ -188,7 +223,7 @@ mod tests {
         let url = Url::from_directory_path(tmp.path()).unwrap();
         let object_store = Arc::new(LocalFileSystem::new());
         let engine =
-            DefaultEngine::new(object_store, Arc::new(TokioBackgroundExecutor::new()), None);
+            DefaultEngine::new(object_store, Arc::new(TokioBackgroundExecutor::new()));
         test_arrow_engine(&engine, &url);
     }
 

test-utils/src/lib.rs

@@ -213,7 +213,6 @@ impl DefaultEngineExtension for DefaultEngine<TokioBackgroundExecutor> {
         Arc::new(DefaultEngine::new(
             object_store,
             TokioBackgroundExecutor::new().into(),
-            None,
         ))
     }
 }
@@ -238,7 +237,7 @@ pub fn engine_store_setup(
         ),
     };
     let executor = Arc::new(TokioBackgroundExecutor::new());
-    let engine = DefaultEngine::new(Arc::clone(&storage), executor, None);
+    let engine = DefaultEngine::new(Arc::clone(&storage), executor);
 
     (storage, engine, url)
 }