Commit bc9a5d8
authored
fix: remove
## What changes are proposed in this pull request?
In the past, we automatically run `cargo-semver-checks` to add
`breaking-change` tag for PRs. However, the label never been removed
after the semver passes. This leads to some PRs incorrectly marked as
breaking.(e.g. This PR is marked as breaking since I didnt rebase to
main and lack of some pub APIs in main. The tag will not be removed
after I rebase).
<!--
**Uncomment** this section if there are any changes affecting public
APIs. Else, **delete** this section.
### This PR affects the following public APIs
If there are breaking changes, please ensure the `breaking-changes`
label gets added by CI, and describe why the changes are needed.
Note that _new_ public APIs are not considered breaking.
-->
## How was this change tested?
Tested in my fork repo. For the `no-breaking` PR
dengsh12#3, label was not added.
For the `breaking` PR
dengsh12#2, at first it is
breaking, after that I restored the breaked API. We can see the robot
add the `breaking-change` label first, and then removed it.breaking-change tag after semver passes (delta-io#1621)1 parent 83bb25a commit bc9a5d8
1 file changed
Lines changed: 6 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
56 | | - | |
| 56 | + | |
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
| |||
66 | 66 | | |
67 | 67 | | |
68 | 68 | | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
69 | 74 | | |
70 | 75 | | |
71 | 76 | | |
| |||
0 commit comments