fix: cycle panel window-switching bugs (full-screen, junk windows, custom modifiers)

[pa]

Summary

A set of fixes to the cycle-panel window switcher, found while testing across full-screen apps, Chromium-based browsers, and customized modifier keys. No new features — bug fixes only.

Fixes

• Full-screen apps showed only "Focus app." Native full-screen apps report an empty kAXWindowsAttribute (the full-screen window lives on its own Space). getWindows() now falls back to the app's focused/main window — which Accessibility still exposes — so the window appears instead of the no-window action. (Reef/Models/Application.swift)

• Chromium browsers listed blank rows. Chromium exposes hidden helper windows (empty title + AXUnknown subrole). Windows are now filtered to standard-or-titled, dropping the junk. (Reef/Models/Application.swift, isRelevantWindow(subrole:title:))

• Custom activate-modifier broke the panel. The flags monitor hardcoded Control to detect "released," so remapping the activate modifier (e.g. to Option) either prevented committing a selection or dismissed the panel immediately. It now commits when the user's configured activate modifiers are released. (Reef/UI/CyclePanel/CyclePanelController.swift)

• Misleading "Focus app" when Accessibility is denied. Without permission, window enumeration always returns empty. The panel now shows an "Enable Accessibility Access…" item that opens the relevant System Settings pane. (Reef/Models/CyclePanelState.swift, Reef/UI/CyclePanel/CyclePanelController.swift)

• Non-unique Window.id. id fell back to 0 for every window whose CGWindowID couldn't be resolved, violating Identifiable uniqueness; now uses a per-instance fallback. (Reef/Models/Window.swift)

• Fragile app-identity check. handleActivate compared apps by display title to choose the starting window index; it now compares by bundle id via a new Application.isSameApplication(as:), which also de-duplicates the identical logic in CyclePanelController.isShowingSwitcher. (Reef/Models/Application.swift, Reef/UI/KeyboardShortcuts/ShortcutController.swift)

• Dev experience: skip the automatic Sparkle update check in DEBUG builds (ad-hoc-signed debug builds can't validate updates and hit an "improperly signed" error). Release behavior unchanged. (Reef/Updates/SparkleConnector.swift)

Known limitation (documented in code)

kAXWindowsAttribute is Space-scoped: when the current Space is a full-screen app's Space, querying another app returns zero windows, so only that app's focused window can be shown — not its full list. Enumerating windows across Spaces would need continuous background AX observation or private Spaces APIs. Noted in Application.getWindows().

Tests

New unit tests (13): activate-modifier commit predicate, the no-windows fallback action (permission-aware), and the junk-window filter. All passing via xcodebuild test.

🤖 Generated with Claude Code

[gouwsxander]

Hi @pa,

Thanks for the PR! It's really cool to see people make use of it being open source!

Currently working on getting a version of PR #30 merged. Once that's done I'd love to get a subset of these features merged as well.

I'll keep you updated!

[pa]

Hi @pa,

Thanks for the PR! It's really cool to see people make use of it being open source!

Currently working on getting a version of PR #30 merged. Once that's done I'd love to get a subset of these features merged as well.

I'll keep you updated!

I've used a ton of window managers like Yabai, AeroSpace, Rectangle, Raycast, and Tuna, but yours is definitely unique. I really love the idea of keeping window switching so simple and clean. Sure I'll wait no problem.