fixup

Author: theseanything

spec/services/metrics/form_count_service_spec.rb

@@ -23,11 +23,13 @@
     before do
       Form.destroy_all
 
+      # Use explicit states instead of :live/:archived traits — those pull in :with_pages,
+      # and each page factory creates its own :form, inflating counts.
       create(:form, :with_group, group:, state: :draft)
-      create(:form, :live, :with_group, group:)
-      create(:form, :live_with_draft, :with_group, group:)
-      create(:form, :archived, :with_group, group:)
-      create(:form, :archived_with_draft, :with_group, group:)
+      create(:form, :with_group, group:, state: :live, pages: [])
+      create(:form, :with_group, group:, state: :live_with_draft, pages: [])
+      create(:form, :with_group, group:, state: :archived, pages: [])
+      create(:form, :with_group, group:, state: :archived_with_draft, pages: [])
       create(:form, state: :draft)
     end