Skip to content

Show backwars routing error for final page#2851

Open
SamJamCul wants to merge 1 commit into
mainfrom
fix-goto-page-ordering-for-routes
Open

Show backwars routing error for final page#2851
SamJamCul wants to merge 1 commit into
mainfrom
fix-goto-page-ordering-for-routes

Conversation

@SamJamCul

Copy link
Copy Markdown
Contributor

When there is a backwards route on the final page of a form, the selection options for routing will be displayed on the routes page, so that it can be corrected.

What problem does this pull request solve?

https://trello.com/c/OGjKv7oo/3140-show-route-selection-drop-downs-on-the-last-question-if-it-has-any-backwards-routes

When there is backwards routing on the final page of a form (probably because there have been pages moved around) we want to show the selection options for that page on the routes page. Normally, we don't give the options for the final page, as they always lead to the end of the form.


Multiple selection backwards route

image

Unconditional backwards route

image

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

When there is a backwards route on the final page of a form, the
selection options for routing will be displayed on the routes page, so
that it can be corrected.
@github-actions

Copy link
Copy Markdown

🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2851.admin.review.forms.service.gov.uk/

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

@hannahkc

Copy link
Copy Markdown
Contributor

Content looks good and works as expected. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants