Skip to content

wip: Use SES to send all confirmation emails#2164

Draft
alice-carr wants to merge 1 commit into
mainfrom
use-ses-to-send-all-confirmation-emails
Draft

wip: Use SES to send all confirmation emails#2164
alice-carr wants to merge 1 commit into
mainfrom
use-ses-to-send-all-confirmation-emails

Conversation

@alice-carr

Copy link
Copy Markdown
Contributor

What problem does this pull request solve?

Trello card: https://trello.com/c/GfBTJbNL/3154-blocked-until-a-sprint-after-copy-of-answers-launch-use-ses-to-send-all-confirmation-emails

We currently use SES to send confirmation emails that include a copy of the user’s answers and Notify to send confirmation emails that do not. We should switch all confirmation emails to use SES.

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

@github-actions

Copy link
Copy Markdown
Contributor

🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2164.submit.review.forms.service.gov.uk/

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant