Skip to content

Render SES emails using markdown#2182

Open
DavidBiddle wants to merge 11 commits into
mainfrom
render-SES-emails-using-markdown
Open

Render SES emails using markdown#2182
DavidBiddle wants to merge 11 commits into
mainfrom
render-SES-emails-using-markdown

Conversation

@DavidBiddle

@DavidBiddle DavidBiddle commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

What problem does this pull request solve?

Trello card: https://trello.com/c/d5t1W2Hs/3151-render-ses-emails-using-markdown

Converts our existing SES email templates into markdown. This means that we no longer have to manually maintain separate HTML and plaintext templates for these emails - instead we can write a single markdown template and render it as HTML and plaintext respectively. It also reduces the number of inline styles we have to maintain.

Screenshots

Submission email

Screen Shot 2026-06-29 at 11 19 00

Daily batch email

Screen Shot 2026-06-29 at 11 19 35

Weekly batch email

Screen Shot 2026-06-29 at 11 19 53

Confirmation email with copy of answers

Screen Shot 2026-06-29 at 11 21 57

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

@DavidBiddle DavidBiddle force-pushed the render-SES-emails-using-markdown branch from 14f5ecd to d4504bb Compare June 25, 2026 13:55
@DavidBiddle DavidBiddle changed the title Render ses emails using markdown Render SES emails using markdown Jun 25, 2026
@DavidBiddle DavidBiddle force-pushed the render-SES-emails-using-markdown branch 4 times, most recently from bf52d67 to 7b529b7 Compare June 29, 2026 10:17
@DavidBiddle DavidBiddle force-pushed the render-SES-emails-using-markdown branch from 7b529b7 to cb708ac Compare June 29, 2026 10:25
@DavidBiddle DavidBiddle marked this pull request as ready for review June 29, 2026 10:25
@github-actions

Copy link
Copy Markdown
Contributor

🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2182.submit.review.forms.service.gov.uk/

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant