the built-in code execution system now uses PATH to locate executables under Windows (closes #41)

Author: gpoore

CHANGELOG.md

@@ -2,6 +2,9 @@
 
 ## v0.5.0 (dev)
 
+* The built-in code execution system now uses PATH to locate executables under
+  Windows.  Previously PATH was ignored under Windows due to the
+  implementation details of Python's `subprocess.Popen()` (#41).
 * Added support for Pandoc command-line options `-C` and `--citeproc` (#42).
 * `rich_output` formats with a `text/*` mime type can now be displayed `raw`,
   `verbatim`, or `verbatim_or_empty`.  For example,

codebraid/codeprocessors/base.py

@@ -17,6 +17,7 @@
 import locale
 import pathlib
 import pkgutil
+import platform
 import queue
 import re
 import subprocess
@@ -642,6 +643,14 @@ def _subproc_default(self, *, session, stdin, stage, stage_num, stage_tot_num, c
         # backslashes will require extra escaping.
         args = shlex.split(cmd)
         failed_proc_stderr = 'COMMAND FAILED (missing program or file):\n  {0}'.format(cmd).encode('utf8')
+        if platform.system() == 'Windows':
+            # Modify args since subprocess.Popen() ignores PATH
+            # * https://bugs.python.org/issue15451
+            # * https://bugs.python.org/issue8557
+            executable = shutil.which(args[0])
+            if executable is None:
+                return FailedProcess(args, stdout=b'', stderr=failed_proc_stderr)
+            args[0] = executable
         if stdin is None:
             stdin_bytes_or_none = None
         else:
@@ -669,6 +678,14 @@ def _subproc_live_output(self, *, session, stdin, stage, stage_num, stage_tot_nu
             raise err.CodebraidError('"live_output" is currently not compatible with running a process that requires STDIN')
         args = shlex.split(cmd)
         failed_proc_stderr = 'COMMAND FAILED (missing program or file):\n  {0}'.format(cmd).encode('utf8')
+        if platform.system() == 'Windows':
+            # Modify args since subprocess.Popen() ignores PATH
+            # * https://bugs.python.org/issue15451
+            # * https://bugs.python.org/issue8557
+            executable = shutil.which(args[0])
+            if executable is None:
+                return FailedProcess(args, stdout=b'', stderr=failed_proc_stderr)
+            args[0] = executable
         # Queue of bytes from stdout and stderr, plus string delims
         print_queue = queue.Queue()
         hash_bytes = session.hash[:64].encode('utf8')

codebraid/version.py

@@ -1,4 +1,4 @@
 # -*- coding: utf-8 -*-
 
 from .fmtversion import get_version_plus_info
-__version__, __version_info__ = get_version_plus_info(0, 5, 0, 'dev', 14)
+__version__, __version_info__ = get_version_plus_info(0, 5, 0, 'dev', 15)