fix: use ClusterFirstWithHostNet when hostNetwork is enabled#10
Merged
thxCode merged 1 commit intogpustack:mainfrom Apr 28, 2026
Merged
fix: use ClusterFirstWithHostNet when hostNetwork is enabled#10thxCode merged 1 commit intogpustack:mainfrom
thxCode merged 1 commit intogpustack:mainfrom
Conversation
Contributor
aiwantaozi
commented
Apr 28, 2026
aiwantaozi
commented
- Benchmark pods fail in Kubernetes with hostNetwork because dnsPolicy is not set gpustack#5133
Signed-off-by: michelia <michelia@seal.io>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Kubernetes pod specification to set the dns_policy to ClusterFirstWithHostNet when host_network is enabled. A review comment correctly identifies that the equal_pods comparison logic must also be updated to include the dns_policy field, otherwise existing workloads will not be updated to reflect this change.
There was a problem hiding this comment.
Pull request overview
Fixes Kubernetes pod DNS behavior when hostNetwork is enabled by ensuring the correct dnsPolicy is applied (per issue #5133).
Changes:
- Set
V1PodSpec.dns_policytoClusterFirstWithHostNetwhenworkload.host_networkis enabled.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.