Skip to content

Add tests for validation that stripIndexFormat and indexFormat must m…#4644

Merged
Kangz merged 1 commit into
gpuweb:mainfrom
Kangz:stripIndexFormat
May 19, 2026
Merged

Add tests for validation that stripIndexFormat and indexFormat must m…#4644
Kangz merged 1 commit into
gpuweb:mainfrom
Kangz:stripIndexFormat

Conversation

@Kangz

@Kangz Kangz commented May 18, 2026

Copy link
Copy Markdown
Collaborator

…atch

Issue: #


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located.
  • Test descriptions are accurate and complete.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Tests avoid over-parameterization (see case count report).

When landing this PR, be sure to make any necessary issue status updates.

@github-actions

Copy link
Copy Markdown

Results for build job (at 62222b3):

+webgpu:api,validation,encoding,cmds,render,draw:index_buffer_format:* - 1 cases, 36 subcases (~36/case)
+webgpu:api,validation,encoding,cmds,render,draw:index_buffer_format_dirtying:* - 1 cases, 6 subcases (~6/case)
-TOTAL: 281247 cases, 2322858 subcases
+TOTAL: 281249 cases, 2322900 subcases

@toji toji left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Kangz Kangz merged commit 97b4991 into gpuweb:main May 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants