Skip to content

Test viewFormats with TRANSIENT_ATTACHMENT#4647

Merged
kainino0x merged 3 commits into
gpuweb:mainfrom
kainino0x:transient-viewformats
May 21, 2026
Merged

Test viewFormats with TRANSIENT_ATTACHMENT#4647
kainino0x merged 3 commits into
gpuweb:mainfrom
kainino0x:transient-viewformats

Conversation

@kainino0x

@kainino0x kainino0x commented May 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

This should not be allowed.

Passes in Chromium with this patch: https://dawn-review.googlesource.com/c/dawn/+/310035

Issue: gpuweb/gpuweb#6263
Spec change: gpuweb/gpuweb#6267

Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located.
  • Test descriptions are accurate and complete.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Tests avoid over-parameterization (see case count report).

When landing this PR, be sure to make any necessary issue status updates.

@github-actions

github-actions Bot commented May 20, 2026 •
edited
Loading

Copy link
Copy Markdown

Results for build job (at 8702550):

+webgpu:api,validation,createTexture:transient_viewFormats:* - 2 cases, 10 subcases (~5/case)
-TOTAL: 281256 cases, 2322907 subcases
+TOTAL: 281258 cases, 2322917 subcases

@kainino0x kainino0x mentioned this pull request May 20, 2026
Closed
@kainino0x kainino0x mentioned this pull request May 21, 2026
Merged
@kainino0x kainino0x marked this pull request as ready for review May 21, 2026 05:51
@kainino0x

kainino0x commented May 21, 2026

Copy link
Copy Markdown
Collaborator Author

PTAL

kainino0x added a commit to gpuweb/gpuweb that referenced this pull request May 21, 2026
@kainino0x
Disallow viewFormats with TRANSIENT_ATTACHMENT (#6267)
532ffc2 
Alternate option would be: allow `viewFormats` to be used, but it can
only be exactly `[format]`.

Tests: gpuweb/cts#4647

Fixes #6263
@kainino0x kainino0x merged commit f72cf53 into gpuweb:main May 21, 2026
1 check passed
@kainino0x kainino0x deleted the transient-viewformats branch May 21, 2026 21:13
copybara-service Bot pushed a commit to google/dawn that referenced this pull request May 22, 2026
@kainino0x
[dawn][native] Disallow viewFormats with TRANSIENT_ATTACHMENT
d7e6def 
Without this, we hit "Failed to create MTLTexture view" in the Metal
backend when trying to create a view with a different format on a
transient texture. (This happens even without Metal validation layers so
it's not a vulnerability, it just loses the device.)

Bug: gpuweb/gpuweb#6263
Test: gpuweb/cts#4647
Change-Id: Ia4b33594b0d47822af34fc5d8294d22f996fdc38
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/310035
Reviewed-by: Fr <beaufort.francois@gmail.com>
Commit-Queue: Fr <beaufort.francois@gmail.com>
Auto-Submit: Kai Ninomiya <kainino@chromium.org>
brave-builds pushed a commit to brave/chromium that referenced this pull request May 22, 2026
Roll Dawn from e935a1b57eb8 to 86a5e62047fb (15 revisions)
5b030e0 
https://dawn.googlesource.com/dawn.git/+log/e935a1b57eb8..86a5e62047fb

2026-05-22 jrprice@google.com [intrinsics] Use absolute paths for imports
2026-05-22 jrprice@google.com [bazel] Export .def and .tmpl files
2026-05-22 jrprice@google.com [bazel] Add BUILD.bazel files for Go packages
2026-05-22 jrprice@google.com Revert "[cmake] Add support for generated sources"
2026-05-22 petermcneeley@google.com [dawn] Add clang-tidy 'cppcoreguidelines-pro-type-member-init'
2026-05-22 jrprice@google.com Revert "[gn] Add support for generated sources"
2026-05-22 kainino@chromium.org [dawn][native] Disallow viewFormats with TRANSIENT_ATTACHMENT
2026-05-22 jiawei.shao@intel.com D3D12: Implement `GetAllocatorMemoryInfo()`
2026-05-22 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from c61c0894e58c to e7a561a5f0b7 (200 revisions)
2026-05-22 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 5e4cafd to 2976e22 (666 revisions)
2026-05-22 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll DirectX Shader Compiler from 8c0d03247b35 to ac0a538752cb (3 revisions)
2026-05-22 senorblanco@chromium.org GL: unskip some BindGroup tests.
2026-05-22 jrprice@google.com [build] Add directory prefix to .tmpl file glob
2026-05-22 jrprice@google.com [build] Track includes to/from generated sources
2026-05-22 jrprice@google.com [gn] Add support for generated sources

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com,rharrison@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-android-arm-deps-rel;luci.chromium.try:dawn-android-arm64-deps-rel;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-mac-arm64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel;luci.chromium.try:dawn-win11-arm64-deps-rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:gpu-fyi-cq-mac-arm64;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:gpu-fyi-cq-android-arm64
Bug: chromium:407730048,chromium:442860471,chromium:491082532,chromium:513255285
Tbr: rharrison@google.com
Test: Test: gpuweb/cts#4647
Change-Id: I8e234fca2fbc2439d4a243dfe19febf04c97acfc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7870967
Commit-Queue: chromium-autoroll@skia-public.iam.gserviceaccount.com <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll@skia-public.iam.gserviceaccount.com <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1635237}
hubot pushed a commit to google/skia that referenced this pull request May 25, 2026
Roll Dawn from 2389260fad26 to 9aa45f938d4b (23 revisions)
e542051 
https://dawn.googlesource.com/dawn.git/+log/2389260fad26..9aa45f938d4b

2026-05-23 dsinclair@chromium.org Simplify resource_table texture checks
2026-05-23 dsinclair@chromium.org Simplify gen for known sampler types
2026-05-23 dsinclair@chromium.org Add bindful/bindless mixed end-to-end tests.
2026-05-23 dsinclair@chromium.org Pull out common code in resource_table
2026-05-23 dsinclair@chromium.org Cleanup resource_table transform.
2026-05-22 kjlubick@google.com Add workarounds for old MSVC
2026-05-22 jrprice@google.com [tint] Add missing newlines to error messages
2026-05-22 jrprice@google.com [intrinsics] Use absolute paths for imports
2026-05-22 jrprice@google.com [bazel] Export .def and .tmpl files
2026-05-22 jrprice@google.com [bazel] Add BUILD.bazel files for Go packages
2026-05-22 jrprice@google.com Revert "[cmake] Add support for generated sources"
2026-05-22 petermcneeley@google.com [dawn] Add clang-tidy 'cppcoreguidelines-pro-type-member-init'
2026-05-22 jrprice@google.com Revert "[gn] Add support for generated sources"
2026-05-22 kainino@chromium.org [dawn][native] Disallow viewFormats with TRANSIENT_ATTACHMENT
2026-05-22 jiawei.shao@intel.com D3D12: Implement `GetAllocatorMemoryInfo()`
2026-05-22 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from c61c0894e58c to e7a561a5f0b7 (200 revisions)
2026-05-22 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 5e4cafd98729 to 2976e22e8416 (666 revisions)
2026-05-22 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll DirectX Shader Compiler from 8c0d03247b35 to ac0a538752cb (3 revisions)
2026-05-22 senorblanco@chromium.org GL: unskip some BindGroup tests.
2026-05-22 jrprice@google.com [build] Add directory prefix to .tmpl file glob
2026-05-22 jrprice@google.com [build] Track includes to/from generated sources
2026-05-22 jrprice@google.com [gn] Add support for generated sources
2026-05-22 jrprice@google.com [cmake] Add support for generated sources

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-skia-autoroll
Please CC cwallez@google.com,rharrison@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Debug-Graphite_Dawn_Vulkan;skia/skia.primary:Test-Mac14-Clang-MacMini9.1-GPU-AppleM1-arm64-Debug-All-ASAN_Graphite_Dawn_Metal;skia/skia.primary:Test-Win11-MSVC-Golo-GPU-QuadroP400-x86_64-Release-All-Graphite_Dawn_D3D12;skia/skia.primary:Test-Win11-MSVC-Golo-GPU-QuadroP400-x86_64-Release-All-Graphite_Dawn_D3D11
Bug: None
Tbr: rharrison@google.com
Test: Test: gpuweb/cts#4647
Change-Id: I51cab1f3d1abc07a2f7d539b3ac045aadb54c064
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1244236
Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
brave-builds pushed a commit to brave/chromium that referenced this pull request May 25, 2026
Roll Skia from 1f26101197bf to 4dd78179e6ec (4 revisions)
9bbfa5c 
https://skia.googlesource.com/skia.git/+log/1f26101197bf..4dd78179e6ec

2026-05-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 78a5d76ed76a to 794dba57f2c1 (14 revisions)
2026-05-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll shaders-base from 33357ebae78c to 9f862803ee5b
2026-05-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 4b069fbc5e1a to 867c02555f37
2026-05-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 2389260fad26 to 9aa45f938d4b (23 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC fmalita@google.com,skiabot@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:gpu-fyi-cq-android-arm64;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:gpu-fyi-cq-mac-arm64;luci.chromium.try:mac14.arm64-blink-rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: chromium:506134561
Tbr: fmalita@google.com
Test: Test: Test: gpuweb/cts#4647
Change-Id: I63904ad38103e59036382bfb67256fdfd30db877
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7874337
Bot-Commit: chromium-autoroll@skia-public.iam.gserviceaccount.com <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll@skia-public.iam.gserviceaccount.com <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1635629}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@beaufortfrancois beaufortfrancois beaufortfrancois approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kainino0x @beaufortfrancois