refactor: apply tsconfig strict true (#2086)

* refactor: apply tsconfig strict true

* refactor: fix tests

* refactor: fix tests

---------

Co-authored-by: kim <kim.phanhoang@epfl.ch>

Author: pyphilia

src/config/env.ts

@@ -14,6 +14,8 @@ const once = (fn) => {
   return function (...args) {
     if (called) return;
     called = true;
+    // eslint-disable-next-line @typescript-eslint/ban-ts-comment
+    // @ts-ignore
     return fn.apply(this, args);
   };
 };

src/services/auth/plugins/captcha/captcha.ts

@@ -25,6 +25,8 @@ export default function captchaPreHandler(
   action: RecaptchaActionType,
   options?: { shouldFail: boolean },
 ): RouteHandlerMethod {
+  // eslint-disable-next-line @typescript-eslint/ban-ts-comment
+  // @ts-ignore
   return async (request: FastifyRequest<{ Body: { captcha: string } }>, _reply: FastifyReply) => {
     const { captcha } = request.body;
     return await validateCaptcha(request, captcha, action, options);

src/services/auth/plugins/magicLink/magicLink.controller.ts

@@ -82,6 +82,8 @@ const plugin: FastifyPluginAsyncTypebox = async (fastify) => {
       schema: auth,
       preHandler: fastifyPassport.authenticate(
         PassportStrategy.WebMagicLink,
+        // eslint-disable-next-line @typescript-eslint/ban-ts-comment
+        // @ts-ignore
         async (request, reply, err, user?: PassportUser, info?: PassportInfo) => {
           // This function is called after the strategy has been executed.
           // It is necessary, so we match the behavior of the original implementation.

src/services/auth/plugins/passport/preHandlers.ts

@@ -79,6 +79,8 @@ export const guestAuthenticateAppsJWT = fastifyPassport.authenticate(
 export function matchOne<R extends RouteGenericInterface>(
   ...strategies: RessourceAuthorizationStrategy<R>[]
 ): RouteHandlerMethod {
+  // eslint-disable-next-line @typescript-eslint/ban-ts-comment
+  // @ts-expect-error
   return async (req: FastifyRequest<R>) => {
     if (!strategies.some((strategy) => strategy.test(req))) {
       // If none of the strategies pass, throw an error.

src/services/auth/plugins/passport/strategies/emailChange.ts

@@ -4,7 +4,7 @@ import { Authenticator } from '@fastify/passport';
 
 import { EMAIL_CHANGE_JWT_SECRET } from '../../../../../config/secrets';
 import { db } from '../../../../../drizzle/db';
-import { MemberNotFound, UnauthorizedMember } from '../../../../../utils/errors';
+import { MemberNotFound, UnauthorizedMember, buildError } from '../../../../../utils/errors';
 import { MemberRepository } from '../../../../member/member.repository';
 import { PassportStrategy } from '../strategies';
 import type { CustomStrategyOptions, StrictVerifiedCallback } from '../types';
@@ -47,9 +47,12 @@ export default (
               false,
             );
           }
-        } catch (err) {
+        } catch (error: unknown) {
           // Exception occurred while fetching member
-          return done(options?.propagateError ? err : new UnauthorizedMember(), false);
+          return done(
+            options?.propagateError ? buildError(error) : new UnauthorizedMember(),
+            false,
+          );
         }
       },
     ),

src/services/auth/plugins/passport/strategies/jwtApps.ts

@@ -4,7 +4,7 @@ import { Authenticator } from '@fastify/passport';
 
 import { APPS_JWT_SECRET } from '../../../../../config/secrets';
 import { db } from '../../../../../drizzle/db';
-import { UnauthorizedMember } from '../../../../../utils/errors';
+import { UnauthorizedMember, buildError } from '../../../../../utils/errors';
 import { AccountRepository } from '../../../../account/account.repository';
 import { ItemRepository } from '../../../../item/item.repository';
 import { PassportStrategy } from '../strategies';
@@ -53,11 +53,14 @@ export default (
               key,
             },
           });
-        } catch (err) {
+        } catch (error: unknown) {
           // Exception occurred while fetching item
           // itemRepository.getOneOrThrow() can fail for many reasons like the item was not found, database error, etc.
           // To avoid leaking information, we prefer to return UnauthorizedMember error.
-          return done(options?.propagateError ? err : new UnauthorizedMember(), false);
+          return done(
+            options?.propagateError ? buildError(error) : new UnauthorizedMember(),
+            false,
+          );
         }
       },
     ),

src/services/auth/plugins/passport/strategies/jwtChallengeVerifier.ts

@@ -5,7 +5,12 @@ import { Authenticator } from '@fastify/passport';
 
 import { JWT_SECRET } from '../../../../../config/secrets';
 import { db } from '../../../../../drizzle/db';
-import { ChallengeFailed, MemberNotFound, UnauthorizedMember } from '../../../../../utils/errors';
+import {
+  ChallengeFailed,
+  MemberNotFound,
+  UnauthorizedMember,
+  buildError,
+} from '../../../../../utils/errors';
 import { AccountRepository } from '../../../../account/account.repository';
 import { SHORT_TOKEN_PARAM } from '../constants';
 import { PassportStrategy } from '../strategies';
@@ -57,9 +62,9 @@ export default (
               false,
             );
           }
-        } catch (err) {
+        } catch (error: unknown) {
           // Exception occurred while fetching member
-          return done(spreadException ? err : new UnauthorizedMember(), false);
+          return done(spreadException ? buildError(error) : new UnauthorizedMember(), false);
         }
       },
     ),

src/services/file/file.service.test.ts

@@ -115,8 +115,8 @@ describe('FileService', () => {
     it('upload failure will delete file', async () => {
       const uploadFileMock = jest.spyOn(s3Repository, 'uploadFiles').mockRejectedValue('error');
       const deleteFileMock = jest.spyOn(s3Repository, 'deleteFiles').mockImplementation(doNothing);
-      await expect(s3FileService.upload(member, uploadPayload)).rejects.toMatchObject(
-        new UploadFileUnexpectedError(expect.anything()),
+      await expect(s3FileService.upload(member, uploadPayload)).rejects.toThrow(
+        new UploadFileUnexpectedError({ memberId: member.id }),
       );
       expect(uploadFileMock).toHaveBeenCalled();
       expect(deleteFileMock).toHaveBeenCalled();
@@ -276,19 +276,19 @@ describe('FileService', () => {
       const copyMock = jest
         .spyOn(s3Repository, 'copyFile')
         .mockImplementation(async () => 'string');
-      await s3FileService.copy(member, copyPayload);
+      await s3FileService.copy(member.id, copyPayload);
       expect(copyMock).toHaveBeenCalled();
     });
 
     it('empty originalPath throws', async () => {
       await expect(
-        s3FileService.copy(member, { ...copyPayload, originalPath: '' }),
+        s3FileService.copy(member.id, { ...copyPayload, originalPath: '' }),
       ).rejects.toMatchObject(new CopyFileInvalidPathError(expect.anything()));
     });
 
     it('empty newFilePath throws', async () => {
       await expect(
-        s3FileService.copy(member, { ...copyPayload, newFilePath: '' }),
+        s3FileService.copy(member.id, { ...copyPayload, newFilePath: '' }),
       ).rejects.toMatchObject(new CopyFileInvalidPathError(expect.anything()));
     });
   });

src/services/file/file.service.ts

@@ -161,7 +161,7 @@ class FileService {
   }
 
   async copy(
-    member: MinimalMember,
+    memberId: MinimalMember['id'],
     data: {
       newId?: string;
       newFilePath: string;
@@ -180,7 +180,7 @@ class FileService {
 
     return this.repository.copyFile({
       newId,
-      memberId: member.id,
+      memberId,
       originalPath,
       newFilePath,
       mimetype,

src/services/file/repositories/local.ts

@@ -69,7 +69,7 @@ export class LocalFileRepository implements FileRepository {
     try {
       await access(this.buildFullPath(filepath));
     } catch (e) {
-      if (e.code === 'ENOENT') {
+      if (e !== null && typeof e === 'object' && 'code' in e && e.code === 'ENOENT') {
         throw new LocalFileNotFound({ filepath });
       }
       throw e;