fix(opti): remove join on accountsTable for getInheritedMany (#1890)

* fix: remove join on accounts table for `getInheritedMany` to lighten query

* fix: commit changes

Author: spaenleh

package.json

@@ -35,7 +35,6 @@
     "watch-debug": "concurrently -k -p \"[{name}]\" -n \"TypeScript,Node\" -c \"cyan.bold,green.bold\" \"yarn watch-ts\" \"yarn serve-debug\"",
     "hooks:uninstall": "husky uninstall",
     "hooks:install": "node .husky/install.mjs",
-    "postinstall": "node .husky/install.mjs",
     "pre-commit": "yarn prettier:check && yarn lint",
     "openapi:generate": "node dist/scripts/generateOpenAPI.js",
     "openapi:lint": "vacuum lint ./openapi.json",

src/services/itemMembership/membership.repository.ts

@@ -404,7 +404,7 @@ export class ItemMembershipRepository {
     inputItems: ItemRaw[],
     accountId: AccountId,
     considerLocal = false,
-  ): Promise<ResultOf<ItemMembershipWithItemAndAccount>> {
+  ): Promise<ResultOf<ItemMembershipWithItem>> {
     if (inputItems.length === 0) {
       return { data: {}, errors: [] };
     }
@@ -423,12 +423,10 @@ export class ItemMembershipRepository {
       .select({
         ...getTableColumns(itemMembershipsTable),
         item: getTableColumns(itemsRawTable),
-        account: getTableColumns(accountsTable),
         // Keep only closest membership per descendant
         descendantId: itemsRawTable.id,
       })
       .from(itemMembershipsTable)
-      .innerJoin(accountsTable, eq(itemMembershipsTable.accountId, accountsTable.id))
       // Map each membership to the item it can affect
       .innerJoin(itemsRawTable, isAncestorOrSelf(itemMembershipsTable.itemPath, itemsRawTable.path))
       .where(and(...andConditions))