Skip to content

Commit 6b6a22a

Browse files
authored
refactor: remove mobile auth secrets (#1915)
* refactor: remove AUTH_TOKEN_JWT_SECRET * refactor: remove REFRESH_TOKEN_JWT_SECRET
1 parent 2dcf733 commit 6b6a22a

15 files changed

Lines changed: 1 addition & 355 deletions

File tree

.github/workflows/deploy-prod.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,6 @@ jobs:
9898
DB_CONNECTION_POOL_SIZE=${{ vars.DB_CONNECTION_POOL_SIZE }}
9999
APPS_JWT_SECRET=${{ secrets.APPS_JWT_SECRET }}
100100
APPS_PUBLISHER_ID=${{ secrets.APPS_PUBLISHER_ID }}
101-
AUTH_TOKEN_JWT_SECRET=${{ secrets.AUTH_TOKEN_JWT_SECRET }}
102101
CLIENT_HOST=${{ vars.CLIENT_HOST }}
103102
COOKIE_DOMAIN=${{ vars.COOKIE_DOMAIN }}
104103
CORS_ORIGIN_REGEX=${{ secrets.CORS_ORIGIN_REGEX }}
@@ -133,7 +132,6 @@ jobs:
133132
PUBLIC_URL=${{ secrets.PUBLIC_URL }}
134133
RECAPTCHA_SECRET_ACCESS_KEY=${{ secrets.RECAPTCHA_SECRET_ACCESS_KEY }}
135134
REDIS_CONNECTION=${{ secrets.REDIS_CONNECTION }}
136-
REFRESH_TOKEN_JWT_SECRET=${{ secrets.REFRESH_TOKEN_JWT_SECRET }}
137135
S3_FILE_ITEM_ACCESS_KEY_ID=${{ secrets.S3_FILE_ITEM_ACCESS_KEY_ID }}
138136
S3_FILE_ITEM_BUCKET=${{ vars.S3_FILE_ITEM_BUCKET }}
139137
FILE_STORAGE_TYPE=${{ vars.FILE_STORAGE_TYPE }}

.github/workflows/deploy-stage.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,6 @@ jobs:
9898
DB_CONNECTION_POOL_SIZE=${{ vars.DB_CONNECTION_POOL_SIZE }}
9999
APPS_JWT_SECRET=${{ secrets.APPS_JWT_SECRET }}
100100
APPS_PUBLISHER_ID=${{ secrets.APPS_PUBLISHER_ID }}
101-
AUTH_TOKEN_JWT_SECRET=${{ secrets.AUTH_TOKEN_JWT_SECRET }}
102101
CLIENT_HOST=${{ vars.CLIENT_HOST }}
103102
COOKIE_DOMAIN=${{ vars.COOKIE_DOMAIN }}
104103
CORS_ORIGIN_REGEX=${{ secrets.CORS_ORIGIN_REGEX }}
@@ -134,7 +133,6 @@ jobs:
134133
PUBLIC_URL=${{ secrets.PUBLIC_URL }}
135134
RECAPTCHA_SECRET_ACCESS_KEY=${{ secrets.RECAPTCHA_SECRET_ACCESS_KEY }}
136135
REDIS_CONNECTION=${{ secrets.REDIS_CONNECTION }}
137-
REFRESH_TOKEN_JWT_SECRET=${{ secrets.REFRESH_TOKEN_JWT_SECRET }}
138136
S3_FILE_ITEM_ACCESS_KEY_ID=${{ secrets.S3_FILE_ITEM_ACCESS_KEY_ID }}
139137
S3_FILE_ITEM_BUCKET=${{ vars.S3_FILE_ITEM_BUCKET }}
140138
FILE_STORAGE_TYPE=${{ vars.FILE_STORAGE_TYPE }}

.github/workflows/test.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ env:
1919
APPS_JWT_SECRET: 0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef
2020
APPS_PUBLISHER_ID: 9c9cea73-f3b7-48a3-aa6e-ead82c0685e7 # mock uuid
2121
GRAASPER_CREATOR_ID: bbbf7cac-6139-45e4-8fbf-4cf767b50b29 # mock uuid
22-
AUTH_TOKEN_JWT_SECRET: 0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef
2322
COOKIE_DOMAIN: localhost
2423
CLIENT_HOST: http://localhost:3114
2524
DB_PASSWORD: docker
@@ -42,7 +41,6 @@ env:
4241
MAILER_CONNECTION: smtp://username:password@localhost:1025
4342
RECAPTCHA_SECRET_ACCESS_KEY: 0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef
4443
REDIS_CONNECTION: 'redis://localhost:6379'
45-
REFRESH_TOKEN_JWT_SECRET: 0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef
4644
S3_FILE_ITEM_ACCESS_KEY_ID: graasp-user
4745
S3_FILE_ITEM_BUCKET: graasp
4846
FILE_STORAGE_TYPE: s3

API Collections/Auth/Mobile/Auth.bru

Lines changed: 0 additions & 23 deletions
This file was deleted.

API Collections/Auth/Mobile/Refresh Token.bru

Lines changed: 0 additions & 20 deletions
This file was deleted.

API Collections/Auth/Mobile/Register.bru

Lines changed: 0 additions & 20 deletions
This file was deleted.

API Collections/Auth/Mobile/Sign In.bru

Lines changed: 0 additions & 19 deletions
This file was deleted.

README.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -130,10 +130,6 @@ SECURE_SESSION_SECRET_KEY=<secret-key>
130130

131131
# JWT secret (can use the same command as for SECURE_SESSION_SECRET_KEY)
132132
JWT_SECRET=<secret-key>
133-
# Auth JWT secret (can use the same command as for SECURE_SESSION_SECRET_KEY)
134-
AUTH_TOKEN_JWT_SECRET=<secret-key>
135-
# Refresh JWT secret (can use the same command as for SECURE_SESSION_SECRET_KEY)
136-
REFRESH_TOKEN_JWT_SECRET=<secret-key>
137133
# Password reset JWT secret (can use the same command as for SECURE_SESSION_SECRET_KEY)
138134
PASSWORD_RESET_JWT_SECRET=<secret-key>
139135
# Email change JWT secret (can use the same command as for SECURE_SESSION_SECRET_KEY)

docker/compose.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,6 @@ x-core_environment: &core_environment
5757
# npx @fastify/secure-session > secret-key && node -e "let fs=require('fs'),file=path.join(__dirname, 'secret-key');console.log(fs.readFileSync(file).toString('hex'));fs.unlinkSync(file)"
5858
SECURE_SESSION_SECRET_KEY: # replace by your own data
5959
JWT_SECRET: # replace by your own data
60-
AUTH_TOKEN_JWT_SECRET: # replace by your own data
61-
REFRESH_TOKEN_JWT_SECRET: # replace by your own data
6260
PASSWORD_RESET_JWT_SECRET: # replace by your own data
6361
EMAIL_CHANGE_JWT_SECRET: # replace by your own data
6462
APPS_JWT_SECRET: # replace by your own data

src/config/secrets.ts

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -32,15 +32,3 @@ export const EMAIL_CHANGE_JWT_EXPIRATION_IN_MINUTES = 1440; // 24 hours
3232

3333
/** Graasp apps authentication */
3434
export const APPS_JWT_SECRET = requiredEnvVar('APPS_JWT_SECRET');
35-
36-
// TODO: remove mobile auth variables as it is deprecated and not supported anymore
37-
/**
38-
* Mobile auth
39-
*/
40-
export const AUTH_TOKEN_JWT_SECRET = requiredEnvVar('AUTH_TOKEN_JWT_SECRET');
41-
/** Auth token expiration, in minutes */
42-
export const AUTH_TOKEN_EXPIRATION_IN_MINUTES = 10080; // 7 days
43-
44-
export const REFRESH_TOKEN_JWT_SECRET = requiredEnvVar('REFRESH_TOKEN_JWT_SECRET');
45-
/** Refresh token expiration, in minutes */
46-
export const REFRESH_TOKEN_EXPIRATION_IN_MINUTES = 86400; // 60 days

0 commit comments

Comments
 (0)