feat: move membership endpoint

Author: kim

src/app.ts

@@ -59,7 +59,6 @@ export default async function (instance: FastifyInstance): Promise<void> {
       })
       .register(fp(MemberServiceApi))
       .register(fp(ItemServiceApi))
-      .register(fp(ItemMembershipServiceApi))
       .register(tagPlugin);
   });
 }

src/services/item/index.ts

@@ -12,6 +12,7 @@ import {
 } from '../../utils/config';
 import chatController from '../chat/chatMessage.controller';
 import graaspItemLogin from '../itemLogin/itemLogin.controller';
+import itemMembershipsPlugin from '../itemMembership/membership.controller';
 import itemController from './item.controller';
 import actionItemPlugin from './plugins/action/itemAction.controller';
 import graaspApps from './plugins/app/app.controller';
@@ -71,6 +72,8 @@ const plugin: FastifyPluginAsync = async (fastify) => {
 
       fastify.register(graaspItemPublish);
 
+      fastify.register(itemMembershipsPlugin);
+
       fastify.register(graaspShortcutPlugin);
 
       fastify.register(thumbnailsPlugin);

src/services/itemMembership/membership.controller.ts

@@ -1,6 +1,5 @@
 import { StatusCodes } from 'http-status-codes';
 
-import { fastifyCors } from '@fastify/cors';
 import { FastifyPluginAsyncTypebox } from '@fastify/type-provider-typebox';
 
 import { resolveDependency } from '../../di/utils';
@@ -14,23 +13,16 @@ import { ItemMembershipService } from './membership.service';
 import MembershipRequestAPI from './plugins/MembershipRequest/membershipRequest.controller';
 import { membershipWsHooks } from './ws/hooks';
 
-const ROUTES_PREFIX = '/item-memberships';
-
 const plugin: FastifyPluginAsyncTypebox = async (fastify) => {
   const itemMembershipService = resolveDependency(ItemMembershipService);
 
   fastify.register(MembershipRequestAPI, {
-    prefix: '/items/:itemId/memberships/requests',
+    prefix: '/:itemId/memberships/requests',
   });
 
   // routes
   fastify.register(
     async function (fastify: FastifyInstanceTypebox) {
-      // add CORS support
-      if (fastify.corsPluginOptions) {
-        fastify.register(fastifyCors, fastify.corsPluginOptions);
-      }
-
       fastify.register(membershipWsHooks);
 
       // get many item's memberships
@@ -94,7 +86,7 @@ const plugin: FastifyPluginAsyncTypebox = async (fastify) => {
         },
       );
     },
-    { prefix: ROUTES_PREFIX },
+    { prefix: '/:itemId/memberships' },
   );
 };
 

src/services/itemMembership/membership.schemas.ts

@@ -97,6 +97,7 @@ export const updateOne = {
 
   params: customType.StrictObject({
     id: customType.UUID(),
+    itemId: customType.UUID(),
   }),
   body: customType.StrictObject({
     permission: customType.EnumString(Object.values(PermissionLevel)),
@@ -116,6 +117,7 @@ export const deleteOne = {
 
   params: customType.StrictObject({
     id: customType.UUID(),
+    itemId: customType.UUID(),
   }),
   querystring: customType.StrictObject({
     purgeBelow: Type.Optional(Type.Boolean()),

src/services/itemMembership/plugins/MembershipRequest/membershipRequest.controller.ts

@@ -34,10 +34,6 @@ const plugin: FastifyPluginAsyncTypebox = async (fastify) => {
   const itemLoginService = resolveDependency(ItemLoginService);
   const authorizationService = resolveDependency(AuthorizationService);
 
-  if (fastify.corsPluginOptions) {
-    await fastify.register(fastifyCors, fastify.corsPluginOptions);
-  }
-
   fastify.get(
     '/',
     {