fix: adapt membership endpointsparams and queries

Author: kim

src/app.ts

@@ -13,7 +13,6 @@ import { schemaRegisterPlugin } from './plugins/typebox';
 import authPlugin from './services/auth';
 import { plugin as passportPlugin } from './services/auth/plugins/passport';
 import ItemServiceApi from './services/item';
-import ItemMembershipServiceApi from './services/itemMembership/membership.controller';
 import { maintenancePlugin } from './services/maintenance/maintenance.controller';
 import MemberServiceApi from './services/member';
 import tagPlugin from './services/tag/tag.controller';

src/services/itemMembership/membership.controller.ts

@@ -30,7 +30,7 @@ const plugin: FastifyPluginAsyncTypebox = async (fastify) => {
       fastify.get(
         '/',
         { schema: getItemMembershipsForItem, preHandler: optionalIsAuthenticated },
-        async ({ user, query: { itemId } }) => {
+        async ({ user, params: { itemId } }) => {
           return itemMembershipService.getForItem(db, user?.account, itemId);
         },
       );
@@ -42,7 +42,7 @@ const plugin: FastifyPluginAsyncTypebox = async (fastify) => {
           schema: create,
           preHandler: [isAuthenticated, matchOne(validatedMemberAccountRole)],
         },
-        async ({ user, query: { itemId }, body }, reply) => {
+        async ({ user, params: { itemId }, body }, reply) => {
           const account = asDefined(user?.account);
           await db.transaction(async (tx) => {
             await itemMembershipService.create(tx, account, {

src/services/itemMembership/membership.schemas.ts

@@ -63,7 +63,7 @@ export const create = {
   summary: 'Create access to item for account',
   description: 'Create access to item for account, given permission',
 
-  querystring: customType.StrictObject({
+  params: customType.StrictObject({
     itemId: customType.UUID(),
   }),
   body: createItemMembershipSchema,
@@ -79,7 +79,7 @@ export const getItemMembershipsForItem = {
   summary: 'Get memberships for one item',
   description: 'Get memberships for one item',
 
-  querystring: customType.StrictObject({
+  params: customType.StrictObject({
     itemId: customType.UUID(),
   }),
   response: {

src/services/itemMembership/plugins/MembershipRequest/membershipRequest.controller.ts

@@ -1,6 +1,5 @@
 import { StatusCodes } from 'http-status-codes';
 
-import { fastifyCors } from '@fastify/cors';
 import { FastifyPluginAsyncTypebox } from '@fastify/type-provider-typebox';
 
 import { MembershipRequestStatus, PermissionLevel } from '@graasp/sdk';

src/services/itemMembership/plugins/MembershipRequest/membershipRequest.schemas.ts

@@ -28,6 +28,7 @@ export const simpleMembershipRequestSchemaRef = registerSchemaAsRef(
 );
 
 export const getAllByItem = {
+  operationId: 'getMembershipRequestsByItemId',
   tags: ['membership-request'],
   summary: 'Get all membership requests for an item',
   description: 'Get all membership requests with member information for an item by its ID',
@@ -42,6 +43,7 @@ export const getAllByItem = {
 } as const satisfies FastifySchema;
 
 export const createOne = {
+  operationId: 'createMembershipRequest',
   tags: ['membership-request'],
   summary: 'Create a membership request',
   description: `Create a membership request for an item with the authenticated member.
@@ -56,6 +58,7 @@ export const createOne = {
 } as const satisfies FastifySchema;
 
 export const getOwn = {
+  operationId: 'getOwnMembershipRequestByItemId',
   tags: ['membership-request'],
   summary: 'Get the status of the membership request for the authenticated member',
   description:
@@ -71,6 +74,7 @@ export const getOwn = {
 } as const satisfies FastifySchema;
 
 export const deleteOne = {
+  operationId: 'deleteMembershipRequest',
   tags: ['membership-request'],
   summary: 'Delete a membership request',
   description: 'Delete a membership request from a member id and an item id.',