fix: update some things

Author: spaenleh

.yarnrc.yml

@@ -9,3 +9,14 @@ postinstall = 'npx corepack enable'
 [settings]
 # This must be enabled to make the hooks work
 experimental = true
+
+[tasks.pnpm-install]
+description = 'Installs dependencies with pnpm'
+run = 'pnpm install'
+sources = ['package.json', 'pnpm-lock.yaml', 'mise.toml']
+outputs = ['node_modules/.pnpm/lock.yaml']
+
+[tasks.dev]
+depends = ["pnpm-install"]
+description = "Run the development server"
+run = "pnpm watch"

mise.toml

@@ -15,10 +15,9 @@
   "packageManager": "pnpm@11.2.1",
   "scripts": {
     "start": "NODE_PATH=./dist node dist/server.js",
-    "build": "yarn lint && yarn build-ts",
+    "build": "pnpm lint && pnpm build-ts",
     "watch-node": "NODE_PATH=./dist nodemon dist/server.js",
     "watch-node:worker": "NODE_PATH=./dist nodemon dist/workers/entrypoint.js",
-    "dev": "yarn run watch",
     "watch": "concurrently -k -p \"[{name}]\" -n \"TypeScript,Server\" -c \"cyan.bold,green.bold\" \"pnpm watch-ts\" \"pnpm watch-node\"",
     "seed": "ts-node -e 'import seed from \"./test/mocks/index\";seed();'",
     "test": "jest --forceExit --verbose --runInBand --detectOpenHandles",

package.json

@@ -122,26 +122,14 @@ export const UploadFileUnexpectedError = createError(
   StatusCodes.INTERNAL_SERVER_ERROR,
 );
 
-export class DownloadFileUnexpectedError extends GraaspFileError {
-  constructor(data?: unknown) {
-    super(
-      {
-        code: 'GPFERR011',
-        statusCode: StatusCodes.INTERNAL_SERVER_ERROR,
-        // TODO: change message
-        message: FAILURE_MESSAGES.DOWNLOAD_FILE_UNEXPECTED_ERROR,
-      },
-      data,
-    );
-  }
-}
+export const DownloadFileUnexpectedError = createError(
+  'GPFERR011',
+  FAILURE_MESSAGES.DOWNLOAD_FILE_UNEXPECTED_ERROR,
+  StatusCodes.INTERNAL_SERVER_ERROR,
+);
 
-export class MalformedFileConfigError extends GraaspFileError {
-  constructor(message: string) {
-    super({
-      code: 'GPFERR012',
-      statusCode: StatusCodes.INTERNAL_SERVER_ERROR,
-      message,
-    });
-  }
-}
+export const MalformedFileConfigError = createError(
+  'GPFERR012',
+  'Malformed configuration for',
+  StatusCodes.INTERNAL_SERVER_ERROR,
+);

src/services/file/utils/errors.ts

@@ -7,15 +7,11 @@ import { MalformedFileConfigError } from './errors';
 
 const verifyLocalConfig = (config?: LocalFileConfiguration) => {
   if (!config?.storageRootPath.startsWith('/')) {
-    throw new MalformedFileConfigError(
-      'graasp-plugin-file: local service storageRootPath is malformed',
-    );
+    throw new MalformedFileConfigError('local service `storageRootPath` is malformed');
   }
 
   if (!config?.localFilesHost) {
-    throw new MalformedFileConfigError(
-      'graasp-plugin-file: local service localFilesHost is not defined',
-    );
+    throw new MalformedFileConfigError('local service `localFilesHost` is not defined');
   }
 
   return config;
@@ -29,7 +25,7 @@ const verifyS3Config = (config?: S3FileConfiguration) => {
     !config?.s3SecretAccessKey
   ) {
     throw new MalformedFileConfigError(
-      'graasp-plugin-file: mandatory options for s3 service missing',
+      's3 service, a mandatory config is missing, check region, bucket accessKey and secretAccessKey are set',
     );
   }