refactor: fix lint errors (#1884)

* refactor: fix lint errors

* refactor: apply PR requested changes

Author: pyphilia

src/plugins/typebox.ts

@@ -3,9 +3,7 @@ import {
   Static,
   StringOptions,
   TProperties,
-  TRef,
   TSchema,
-  TUnsafe,
   Type,
   UnsafeOptions,
 } from '@sinclair/typebox';

src/services/auth/plugins/passport/strategies/jwtChallengeVerifier.ts

@@ -39,6 +39,7 @@ export default (
             return done(spreadException ? new ChallengeFailed() : new UnauthorizedMember(), false);
           }
         } catch (err) {
+          console.error(err);
           // Exception occurred while comparing challenge
           return done(spreadException ? new ChallengeFailed() : new UnauthorizedMember(), false);
         }

src/services/chat/chatMessage.controller.ts

@@ -85,7 +85,7 @@ const plugin: FastifyPluginAsyncTypebox<GraaspChatPluginOptions> = async (fastif
         try {
           websockets.publish(itemChatTopic, message.itemId, ItemChatEvent('publish', message));
         } catch (e) {
-          fastify.log.error(e);
+          request.log.error(e);
         }
 
         return message;
@@ -119,7 +119,7 @@ const plugin: FastifyPluginAsyncTypebox<GraaspChatPluginOptions> = async (fastif
         try {
           websockets.publish(itemChatTopic, message.itemId, ItemChatEvent('update', message));
         } catch (e) {
-          fastify.log.error(e);
+          request.log.error(e);
         }
 
         return message;
@@ -149,7 +149,7 @@ const plugin: FastifyPluginAsyncTypebox<GraaspChatPluginOptions> = async (fastif
         try {
           websockets.publish(itemChatTopic, message.itemId, ItemChatEvent('delete', message));
         } catch (e) {
-          fastify.log.error(e);
+          request.log.error(e);
         }
 
         return message;
@@ -179,7 +179,7 @@ const plugin: FastifyPluginAsyncTypebox<GraaspChatPluginOptions> = async (fastif
         try {
           websockets.publish(itemChatTopic, itemId, ItemChatEvent('clear'));
         } catch (e) {
-          fastify.log.error(e);
+          request.log.error(e);
         }
       },
     );

src/services/item/item.controller.read.test.ts

@@ -3,50 +3,18 @@ import { v4 as uuidv4 } from 'uuid';
 
 import { FastifyInstance } from 'fastify';
 
-import { HttpMethod, ItemType, PermissionLevel, ResultOf } from '@graasp/sdk';
+import { HttpMethod, ItemType, PermissionLevel } from '@graasp/sdk';
 
 import build, { clearDatabase, mockAuthenticate, unmockAuthenticate } from '../../../test/app';
 import { seedFromJson } from '../../../test/mocks/seed';
 import { db } from '../../drizzle/db';
-import { ItemMembershipRaw, ItemVisibilityRaw } from '../../drizzle/types';
-import { MinimalMember } from '../../types';
 import { assertIsDefined } from '../../utils/assertions';
 import { ItemNotFound, MemberCannotAccess } from '../../utils/errors';
 import { assertIsMemberForTest } from '../authentication';
 import { ItemWrapper, PackedItem } from './ItemWrapper';
 import { expectManyPackedItems, expectPackedItem, expectThumbnails } from './test/fixtures/items';
 import { Ordering, SortBy } from './types';
 
-/**
- *
- * @param resultItems ResultOf items
- * @param correctItems
- * @param itemMemberships we suppose item memberships is ordered in the same order as correctItems
- * @param creator
- * @param itemVisibilities
- */
-const expectResultOfPackedItems = (
-  resultItems: ResultOf<PackedItem>,
-  correctItems,
-  itemMemberships?: ItemMembershipRaw[],
-  creator?: MinimalMember,
-  itemVisibilities?: ItemVisibilityRaw[],
-) => {
-  correctItems.forEach(({ id, path }) => {
-    const idx = correctItems.findIndex(({ id: thisId }) => thisId === id);
-    const item = resultItems[id];
-    expectPackedItem(
-      item,
-      new ItemWrapper(
-        { ...correctItems[idx], creator },
-        itemMemberships?.[idx],
-        itemVisibilities?.filter((iv) => path.includes(iv.itemPath)),
-      ).packed(),
-      creator,
-    );
-  });
-};
-
 // Mock S3 libraries
 const deleteObjectMock = jest.fn(async () => console.debug('deleteObjectMock'));
 const copyObjectMock = jest.fn(async () => console.debug('copyObjectMock'));

src/services/item/item.controller.update.test.ts

@@ -26,7 +26,6 @@ import { SeedActor, seedFromJson } from '../../../test/mocks/seed';
 import { db } from '../../drizzle/db';
 import { isDirectChild } from '../../drizzle/operations';
 import { itemGeolocationsTable, itemMembershipsTable, itemsRawTable } from '../../drizzle/schema';
-import { BaseLogger } from '../../logger';
 import { assertIsDefined } from '../../utils/assertions';
 import {
   HierarchyTooDeep,

src/services/item/item.repository.test.ts

@@ -70,7 +70,7 @@ const getOrderForItemId = async (itemId: ItemRaw['id']): Promise<number | null>
   try {
     const res = await db.select().from(items).where(eq(items.id, itemId));
     return res[0].order;
-  } catch (e) {
+  } catch (_e) {
     return null;
   }
 };

src/services/item/item.repository.ts

@@ -74,7 +74,6 @@ import {
   FILE_METADATA_MAX_PAGE_SIZE,
   FILE_METADATA_MIN_PAGE,
 } from '../member/constants';
-import { mapById } from '../utils';
 import { DEFAULT_ORDER, IS_COPY_REGEX, ITEMS_PAGE_SIZE_MAX } from './constants';
 import { FolderItem, isItemType } from './discrimination';
 import { ItemOrderingError } from './errors';

src/services/item/item.schemas.packed.ts

@@ -3,7 +3,7 @@ import { StatusCodes } from 'http-status-codes';
 
 import { FastifySchema } from 'fastify';
 
-import { ItemType, MAX_TARGETS_FOR_READ_REQUEST, PermissionLevel } from '@graasp/sdk';
+import { ItemType, PermissionLevel } from '@graasp/sdk';
 
 import { customType, registerSchemaAsRef } from '../../plugins/typebox';
 import { errorSchemaRef } from '../../schemas/global';

src/services/item/item.service.ts

@@ -435,6 +435,7 @@ export class ItemService {
       // update index
       await this.meilisearchWrapper.index(dbConnection, Object.values(publishedInfo));
     } catch (e) {
+      this.log.error(e);
       this.log.error('Error during indexation, Meilisearch may be down');
     }
   }
@@ -622,6 +623,7 @@ export class ItemService {
         await this.meilisearchWrapper.indexOne(dbConnection, published);
       }
     } catch (e) {
+      this.log.error(e);
       this.log.error('Error during indexation, Meilisearch may be down');
     }
 

src/services/item/plugins/action/itemAction.controller.ts

@@ -18,7 +18,6 @@ import {
   S3FileConfiguration,
 } from '../../../file/interfaces/configuration';
 import { validatedMemberAccountRole } from '../../../member/strategies/validatedMemberAccountRole';
-import { ItemService } from '../../item.service';
 import {
   ItemOpFeedbackErrorEvent,
   ItemOpFeedbackEvent,