fix: remove item name regex (#2093)

Author: spaenleh

src/plugins/typebox.ts

@@ -23,7 +23,6 @@ import type {
 
 import { MAX_ITEM_NAME_LENGTH, MAX_USERNAME_LENGTH, MIN_USERNAME_LENGTH } from '@graasp/sdk';
 
-import { ITEM_NAME_REGEX } from '../schemas/regex';
 import { discriminable } from './typebox/discriminable';
 
 /**
@@ -114,7 +113,6 @@ export const customType = {
       ...options,
       minLength: 1,
       maxLength: MAX_ITEM_NAME_LENGTH,
-      pattern: ITEM_NAME_REGEX,
     }),
 } as const;
 

src/schemas/regex.spec.ts

@@ -142,6 +142,10 @@ describe('Item routes tests', () => {
       });
 
       it('Bad request if name is invalid', async () => {
+        const { actor } = await seedFromJson();
+        assertIsDefined(actor);
+        assertIsMemberForTest(actor);
+        mockAuthenticate(actor);
         // by default the item creator use an invalid item type
         const newItem = FolderItemFactory({ name: '' });
         const response = await app.inject({
@@ -152,15 +156,15 @@ describe('Item routes tests', () => {
         expect(response.statusMessage).toEqual(ReasonPhrases.BAD_REQUEST);
         expect(response.statusCode).toBe(StatusCodes.BAD_REQUEST);
 
-        // by default the item creator use an invalid item type
+        // a single space is a valid name for the item
         const newItem1 = FolderItemFactory({ name: ' ' });
         const response1 = await app.inject({
           method: HttpMethod.Post,
           url: '/api/items',
           payload: newItem1,
         });
-        expect(response1.statusMessage).toEqual(ReasonPhrases.BAD_REQUEST);
-        expect(response1.statusCode).toBe(StatusCodes.BAD_REQUEST);
+        expect(response1.statusMessage).toEqual(ReasonPhrases.OK);
+        expect(response1.statusCode).toBe(StatusCodes.OK);
       });
 
       it('Bad request if type is invalid', async () => {

src/schemas/regex.ts

@@ -393,7 +393,11 @@ describe('Capsule routes tests', () => {
       });
 
       it('Bad request if name is invalid', async () => {
-        // by default the item creator use an invalid item type
+        const { actor } = await seedFromJson();
+        assertIsDefined(actor);
+        assertIsMemberForTest(actor);
+        mockAuthenticate(actor);
+        // try to create an item with an empty name should fail
         const newItem = CapsuleItemFactory({ name: '' });
         const response = await app.inject({
           method: HttpMethod.Post,
@@ -403,15 +407,15 @@ describe('Capsule routes tests', () => {
         expect(response.statusMessage).toEqual(ReasonPhrases.BAD_REQUEST);
         expect(response.statusCode).toBe(StatusCodes.BAD_REQUEST);
 
-        // by default the item creator use an invalid item type
+        // creating an item with a name made of spaces is allowed
         const newItem1 = CapsuleItemFactory({ name: ' ' });
         const response1 = await app.inject({
           method: HttpMethod.Post,
           url: '/api/items/capsules',
           payload: newItem1,
         });
-        expect(response1.statusMessage).toEqual(ReasonPhrases.BAD_REQUEST);
-        expect(response1.statusCode).toBe(StatusCodes.BAD_REQUEST);
+        expect(response1.statusMessage).toEqual(ReasonPhrases.OK);
+        expect(response1.statusCode).toBe(StatusCodes.OK);
       });
 
       it('Bad request if parentId id is invalid', async () => {

src/services/item/item.controller.update.test.ts

@@ -495,6 +495,10 @@ describe('Folder routes tests', () => {
       });
 
       it('Bad request if name is invalid', async () => {
+        const { actor } = await seedFromJson();
+        assertIsDefined(actor);
+        assertIsMember(actor);
+        mockAuthenticate(actor);
         // by default the item creator use an invalid item type
         const newItem = FolderItemFactory({ name: '' });
         const response = await app.inject({
@@ -512,8 +516,8 @@ describe('Folder routes tests', () => {
           url: '/api/items/folders',
           payload: newItem1,
         });
-        expect(response1.statusMessage).toEqual(ReasonPhrases.BAD_REQUEST);
-        expect(response1.statusCode).toBe(StatusCodes.BAD_REQUEST);
+        expect(response1.statusMessage).toEqual(ReasonPhrases.OK);
+        expect(response1.statusCode).toBe(StatusCodes.OK);
       });
 
       it('Bad request if parentId id is invalid', async () => {