Skip to content

Commit fe737ae

Browse files
pyphiliapyphilia
authored
refactor: pass account id instead of complete account to authorization (#1924)
* refactor: pass account id instead of complete account to authorization * refactor: fix test
1 parent 2f71d70 commit fe737ae

53 files changed

Lines changed: 390 additions & 332 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎docs/architecture.md‎

Lines changed: 0 additions & 33 deletions
This file was deleted.

‎src/services/authorizedItem.service.getPropertiesForItem.test.ts‎

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ describe('getPropertiesForItem', () => {
5454
await expect(
5555
authorizationService.getPropertiesForItem(MOCK_DB, {
5656
permission: PermissionLevel.Admin,
57-
actor: MEMBER,
57+
accountId: MEMBER.id,
5858
item: ITEM,
5959
}),
6060
).rejects.toBeInstanceOf(Error);
@@ -72,7 +72,7 @@ describe('getPropertiesForItem', () => {
7272
await expect(
7373
authorizationService.getPropertiesForItem(MOCK_DB, {
7474
permission,
75-
actor: MEMBER,
75+
accountId: MEMBER.id,
7676
item: ITEM,
7777
}),
7878
).rejects.toBeInstanceOf(rejects);
@@ -90,7 +90,7 @@ describe('getPropertiesForItem', () => {
9090
expect(
9191
await authorizationService.getPropertiesForItem(MOCK_DB, {
9292
permission,
93-
actor: MEMBER,
93+
accountId: MEMBER.id,
9494
item: ITEM,
9595
}),
9696
).toMatchObject({ itemMembership: readMembership });
@@ -102,7 +102,7 @@ describe('getPropertiesForItem', () => {
102102
await expect(
103103
authorizationService.getPropertiesForItem(MOCK_DB, {
104104
permission,
105-
actor: MEMBER,
105+
accountId: MEMBER.id,
106106
item: ITEM,
107107
}),
108108
).rejects.toBeInstanceOf(rejects);
@@ -122,7 +122,7 @@ describe('getPropertiesForItem', () => {
122122
expect(
123123
await authorizationService.getPropertiesForItem(MOCK_DB, {
124124
permission,
125-
actor: MEMBER,
125+
accountId: MEMBER.id,
126126
item: ITEM,
127127
}),
128128
).toMatchObject({ itemMembership: writeMembership });
@@ -134,7 +134,7 @@ describe('getPropertiesForItem', () => {
134134
await expect(
135135
authorizationService.getPropertiesForItem(MOCK_DB, {
136136
permission,
137-
actor: MEMBER,
137+
accountId: MEMBER.id,
138138
item: ITEM,
139139
}),
140140
).rejects.toBeInstanceOf(rejects);
@@ -152,7 +152,7 @@ describe('getPropertiesForItem', () => {
152152
expect(
153153
await authorizationService.getPropertiesForItem(MOCK_DB, {
154154
permission,
155-
actor: MEMBER,
155+
accountId: MEMBER.id,
156156
item: ITEM,
157157
}),
158158
).toMatchObject({ itemMembership: adminMembership });
@@ -171,7 +171,7 @@ describe('getPropertiesForItem', () => {
171171
expect(
172172
await authorizationService.getPropertiesForItem(MOCK_DB, {
173173
permission,
174-
actor: MEMBER,
174+
accountId: MEMBER.id,
175175
item: ITEM,
176176
}),
177177
).toMatchObject({ itemMembership: null });
@@ -189,7 +189,7 @@ describe('getPropertiesForItem', () => {
189189
await expect(
190190
authorizationService.getPropertiesForItem(MOCK_DB, {
191191
permission,
192-
actor: MEMBER,
192+
accountId: MEMBER.id,
193193
item: ITEM,
194194
}),
195195
).rejects.toBeInstanceOf(rejects);
@@ -209,7 +209,7 @@ describe('getPropertiesForItem', () => {
209209
expect(
210210
await authorizationService.getPropertiesForItem(MOCK_DB, {
211211
permission,
212-
actor: MEMBER,
212+
accountId: MEMBER.id,
213213
item: ITEM,
214214
}),
215215
).toMatchObject({ itemMembership: readMembership });
@@ -227,7 +227,7 @@ describe('getPropertiesForItem', () => {
227227
await expect(
228228
authorizationService.getPropertiesForItem(MOCK_DB, {
229229
permission,
230-
actor: MEMBER,
230+
accountId: MEMBER.id,
231231
item: ITEM,
232232
}),
233233
).rejects.toBeInstanceOf(rejects);
@@ -249,7 +249,7 @@ describe('getPropertiesForItem', () => {
249249
expect(
250250
await authorizationService.getPropertiesForItem(MOCK_DB, {
251251
permission,
252-
actor: MEMBER,
252+
accountId: MEMBER.id,
253253
item: ITEM,
254254
}),
255255
).toMatchObject({ itemMembership: writeMembership });
@@ -264,7 +264,7 @@ describe('getPropertiesForItem', () => {
264264
await expect(
265265
authorizationService.getPropertiesForItem(MOCK_DB, {
266266
permission,
267-
actor: MEMBER,
267+
accountId: MEMBER.id,
268268
item: ITEM,
269269
}),
270270
).rejects.toBeInstanceOf(rejects);
@@ -285,7 +285,7 @@ describe('getPropertiesForItem', () => {
285285
expect(
286286
await authorizationService.getPropertiesForItem(MOCK_DB, {
287287
permission,
288-
actor: MEMBER,
288+
accountId: MEMBER.id,
289289
item: ITEM,
290290
}),
291291
).toMatchObject({ itemMembership: adminMembership });
@@ -316,7 +316,7 @@ describe('getPropertiesForItem', () => {
316316
await expect(
317317
authorizationService.getPropertiesForItem(MOCK_DB, {
318318
permission,
319-
actor: MEMBER,
319+
accountId: MEMBER.id,
320320
item: ITEM,
321321
}),
322322
).rejects.toBeInstanceOf(rejects);
@@ -338,7 +338,7 @@ describe('getPropertiesForItem', () => {
338338
await expect(
339339
authorizationService.getPropertiesForItem(MOCK_DB, {
340340
permission,
341-
actor: MEMBER,
341+
accountId: MEMBER.id,
342342
item: ITEM,
343343
}),
344344
).rejects.toBeInstanceOf(rejects);
@@ -359,7 +359,7 @@ describe('getPropertiesForItem', () => {
359359
expect(
360360
await authorizationService.getPropertiesForItem(MOCK_DB, {
361361
permission,
362-
actor: MEMBER,
362+
accountId: MEMBER.id,
363363
item: ITEM,
364364
}),
365365
).toMatchObject({ itemMembership: writeMembership });
@@ -371,7 +371,7 @@ describe('getPropertiesForItem', () => {
371371
await expect(
372372
authorizationService.getPropertiesForItem(MOCK_DB, {
373373
permission,
374-
actor: MEMBER,
374+
accountId: MEMBER.id,
375375
item: ITEM,
376376
}),
377377
).rejects.toBeInstanceOf(rejects);
@@ -392,7 +392,7 @@ describe('getPropertiesForItem', () => {
392392
expect(
393393
await authorizationService.getPropertiesForItem(MOCK_DB, {
394394
permission,
395-
actor: MEMBER,
395+
accountId: MEMBER.id,
396396
item: ITEM,
397397
}),
398398
).toMatchObject({ itemMembership: adminMembership });
@@ -414,7 +414,7 @@ describe('getPropertiesForItem', () => {
414414
await expect(
415415
authorizationService.getPropertiesForItem(MOCK_DB, {
416416
permission,
417-
actor: MEMBER,
417+
accountId: MEMBER.id,
418418
item: ITEM,
419419
}),
420420
).rejects.toBeInstanceOf(rejects);
@@ -436,7 +436,7 @@ describe('getPropertiesForItem', () => {
436436
await expect(
437437
authorizationService.getPropertiesForItem(MOCK_DB, {
438438
permission,
439-
actor: MEMBER,
439+
accountId: MEMBER.id,
440440
item: ITEM,
441441
}),
442442
).rejects.toBeInstanceOf(rejects);
@@ -457,7 +457,7 @@ describe('getPropertiesForItem', () => {
457457
expect(
458458
await authorizationService.getPropertiesForItem(MOCK_DB, {
459459
permission,
460-
actor: MEMBER,
460+
accountId: MEMBER.id,
461461
item: ITEM,
462462
}),
463463
).toMatchObject({ itemMembership: writeMembership });
@@ -469,7 +469,7 @@ describe('getPropertiesForItem', () => {
469469
await expect(
470470
authorizationService.getPropertiesForItem(MOCK_DB, {
471471
permission,
472-
actor: MEMBER,
472+
accountId: MEMBER.id,
473473
item: ITEM,
474474
}),
475475
).rejects.toBeInstanceOf(rejects);
@@ -490,7 +490,7 @@ describe('getPropertiesForItem', () => {
490490
expect(
491491
await authorizationService.getPropertiesForItem(MOCK_DB, {
492492
permission,
493-
actor: MEMBER,
493+
accountId: MEMBER.id,
494494
item: ITEM,
495495
}),
496496
).toMatchObject({ itemMembership: adminMembership });

0 commit comments

Comments
 (0)