refactor: refactor file service for app data#1757
Merged
Merged
Conversation
|
969f7c7 to
5a6e019
Compare
spaenleh
approved these changes
Jul 8, 2025
Member
spaenleh
left a comment
There was a problem hiding this comment.
Changes look good ! Thank you for this refactor !
fb883cd to
cbebd15
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



I moved from
to
This change is motivated by removing hooks.
The original idea was to have a separated plugin, so that it is easy to remove if we don't need it.
We now take the assumption file for app data is a core feature, so I merged both plugins.
AppDataServicenow has aAppDataFileServiceAdapter. This service is in charge of reusing aFileServicefor the purpose of app-data.ref #1635