Skip to content

refactor: refactor file service for app data#1757

Merged
pyphilia merged 4 commits into
mainfrom
refactor-app-data-file
Jul 18, 2025
Merged

refactor: refactor file service for app data#1757
pyphilia merged 4 commits into
mainfrom
refactor-app-data-file

Conversation

@pyphilia
Copy link
Copy Markdown
Contributor

@pyphilia pyphilia commented Feb 14, 2025

I moved from

.
├── item/plugins/app/appData         
│   ├── index.ts   
│   ├── schemas.ts   
│   ├── service.ts   
│   ├── plugins/file
│       ├── index.ts
│       ├── service.ts
├── ...

to

.
├── item/plugins/app/appData         
│   ├── index.ts   
│   ├── schemas.ts   
│   ├── service.ts    
│   ├── appDataFileServiceAdapter.ts    
├── ...

This change is motivated by removing hooks.

The original idea was to have a separated plugin, so that it is easy to remove if we don't need it.
We now take the assumption file for app data is a core feature, so I merged both plugins.
AppDataService now has a AppDataFileServiceAdapter. This service is in charge of reusing a FileService for the purpose of app-data.

ref #1635

@pyphilia pyphilia self-assigned this Feb 14, 2025
@sonarqubecloud
Copy link
Copy Markdown

@pyphilia pyphilia force-pushed the refactor-app-data-file branch from 969f7c7 to 5a6e019 Compare July 4, 2025 15:27
@pyphilia pyphilia requested a review from spaenleh July 7, 2025 12:54
Copy link
Copy Markdown
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good ! Thank you for this refactor !

Comment thread src/services/item/plugins/app/appData/appData.controller.ts Outdated
Comment thread src/services/item/plugins/app/appData/appData.controller.ts Outdated
Comment thread src/services/item/plugins/app/appData/appData.controller.ts
Comment thread src/services/item/plugins/app/appData/appData.schemas.ts
Comment thread src/services/item/plugins/app/appData/appData.service.ts
Comment thread src/services/item/plugins/app/appData/appData.service.ts
Comment thread src/services/item/plugins/app/appData/appDataFileServiceAdapter.ts Outdated
Comment thread src/services/item/plugins/app/appData/appDataFileServiceAdapter.ts Outdated
Comment thread src/services/item/plugins/app/appData/appDataFileServiceAdapter.ts Outdated
Comment thread src/services/item/plugins/app/appData/appDataFileServiceAdapter.ts Outdated
@pyphilia pyphilia marked this pull request as ready for review July 18, 2025 14:35
@pyphilia pyphilia force-pushed the refactor-app-data-file branch from fb883cd to cbebd15 Compare July 18, 2025 14:35
@sonarqubecloud
Copy link
Copy Markdown

@pyphilia pyphilia added this pull request to the merge queue Jul 18, 2025
Merged via the queue into main with commit 001009c Jul 18, 2025
9 checks passed
@pyphilia pyphilia deleted the refactor-app-data-file branch July 18, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants