fix(files-upload): return simple error if exists#1866
Merged
Conversation
spaenleh
approved these changes
May 9, 2025
pyphilia
force-pushed
the
file-upload-return-value
branch
from
f7c5283 to
6efbe9d
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of a
ResultOf, the endpoint throws an error if one exists.This return is a bit wrong, since some files might have still been uploaded. But it is easier for the frontend to correctly show errors.
The best solution would be to return
ACCEPTEDand deal with websockets to correctly return many status codes. But it requires some refactors (websockets, progress, refactor to useuploadManyinstead of in serie, etc)