fix: expose with the /api prefix#2037
Merged
Merged
Conversation
spaenleh
force-pushed
the
single-origin
branch
from
c6d306c to
d85ba38
Compare
pyphilia
approved these changes
Nov 13, 2025
pyphilia
left a comment
pyphilia
left a comment
Contributor
There was a problem hiding this comment.
Huge PR! A step towards ESM ;)
spaenleh
had a problem deploying
to
development
GitHub Actions
Failure
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR:
/apiprefix/healthroute stays at the root/apiprefix before forwarding requests to the core containerI made the following changes:
The "legacy" server is accessible at
localhost:3000where the nginx forwards requests. Use paths without /api if using this. This mimicks the api.graasp.org behaviour.A new
localhost:3001that is the core container directly. Here you need to use paths with the/apiprefix. This is designed to be used as the target for single origin and as a target for the vite server proxy.Example usage:
http://localhost:3000/items/:id-> via nginx proxyhttp://localhost:3001/api/items/:id-> direct to backend