Skip to content

Commit b8b7526

Browse files
bigdazclaude
andauthored
Upgrade shadow to 9.4.3 and drop redundant vulnerability constraints (#222)
## What - Bump `com.gradleup.shadow` **9.2.2 → 9.4.3** (latest release). - Remove the `buildscript { … constraints { … } }` block in `plugin/build.gradle.kts` that forced patched `commons-io` / `log4j-core` versions. - Drop the `apache-log4j-core` version-catalog entry (its only consumer was that constraint). `apache-commons-io` is kept — it's still used by `plugin-test`. ## Why Shadow 9.4.3 now ships patched transitive dependencies natively (`commons-io:2.22.0`, `log4j-core:2.26.0`), which are newer than the versions the constraints pinned. The constraints had become no-ops, so they're removed along with the now-unused catalog entry. ## Gradle version Left at **8.14.4**. The latest shadow does *not* require Gradle 9 — 9.4.3 builds and tests cleanly on 8.14.4 — so no Gradle bump is needed and the plugin's Gradle 5 runtime compatibility is unaffected. Note: this does not remove the `org.gradle.api.plugins.Convention` deprecation warning — that originates from the Kotlin Gradle plugin (1.8.10), not shadow. ## Verification - `:plugin:test` ✅ - `:plugin-test:test` (integration suite) ✅ - `:plugin:shadowJar` ✅ — buildscript classpath still resolves `commons-io:2.22.0` / `log4j-core:2.26.0` 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 8e1f7e4 commit b8b7526

2 files changed

Lines changed: 1 addition & 17 deletions

File tree

gradle/libs.versions.toml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ jackson-databind = { group = "com.fasterxml.jackson.core", name = "jackson-datab
88
jackson-parameter-names = { group = "com.fasterxml.jackson.module", name = "jackson-module-parameter-names" }
99

1010
apache-commons-io = { group = "commons-io", name = "commons-io", version = "2.21.0" }
11-
apache-log4j-core = { group = "org.apache.logging.log4j", name = "log4j-core", version = "2.25.4" }
1211

1312
github-packageurl = { group = "com.github.package-url", name = "packageurl-java", version = "1.5.0" }
1413

@@ -25,5 +24,5 @@ jetbrains-annotations = { group = "org.jetbrains", name = "annotations", version
2524
google-gson = { group = "com.google.code.gson", name = "gson", version = "2.13.2" }
2625

2726
[plugins]
28-
shadow-jar = { id = "com.gradleup.shadow", version = "9.2.2"}
27+
shadow-jar = { id = "com.gradleup.shadow", version = "9.4.3"}
2928
plugin-publish = { id = "com.gradle.plugin-publish", version = "2.1.0" }

plugin/build.gradle.kts

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -4,21 +4,6 @@ import org.jetbrains.kotlin.gradle.dsl.JvmTarget
44
import org.jetbrains.kotlin.gradle.dsl.KotlinVersion
55
import org.jetbrains.kotlin.gradle.tasks.KotlinCompile
66

7-
// Upgrade transitive dependencies in plugin classpath
8-
buildscript {
9-
repositories {
10-
gradlePluginPortal()
11-
}
12-
dependencies {
13-
constraints {
14-
// The com.gradleup.shadow plugin depends on vulnerable library releases.
15-
// We constrain these to newer, patched versions.
16-
classpath(libs.apache.commons.io)
17-
classpath(libs.apache.log4j.core)
18-
}
19-
}
20-
}
21-
227
plugins {
238
kotlin("jvm") version(libs.versions.kotlin)
249
alias(libs.plugins.plugin.publish)

0 commit comments

Comments
 (0)