feat: separate helm chart for CRDs#507
Open
mariuskimmina wants to merge 6 commits into
Open
Conversation
Signed-off-by: Marius Kimmina <marius@adjoe.io>
Signed-off-by: Marius Kimmina <marius@adjoe.io>
Signed-off-by: Marius Kimmina <marius@adjoe.io>
Signed-off-by: Marius Kimmina <marius@adjoe.io>
Signed-off-by: Marius Kimmina <marius@adjoe.io>
Signed-off-by: Marius Kimmina <marius@adjoe.io>
Author
|
Note: might want to wait for #500 and not include the |
Author
|
Tested it now and it seems to be working fine. I tested on a simple Then installing removing the I then created a very minimal All of this worked so I am going to mark this as ready for review now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #505
Supersedes #506
This is a first draft for a new helm chart
k6-crds.https://helm.sh/docs/chart_best_practices/custom_resource_definitions/#method-2-separate-charts
Examples of other projects following this approach:
The current approach of having of having the CRDs defined under
templates/crdsis not a recommended pattern byhelm. We could move CRDs to a dedicated/crds/folder but as seen in #506 that creates it's own problems due to a lack of templating.So far I liked the approach of having a separate chart for CRDs whenever I encountered it.
I think we can do this in two steps
k6-crdschart (this PR).k6-operatorchart and addk6-crdschart as a dependency.Converting to Draft as I didn't get to testing this yet.