Fix: Handle large hostname lists (>500 IPs)#642
Draft
omriKaltura wants to merge 1 commit into
Draft
Conversation
…too long' error - Added constant maxHostnamesPerBatch = 500 to define the maximum number of hostnames per batch - Implemented batching logic to split the hostnames list into smaller chunks - Created a loop to generate a starter job for each batch - Added unique naming for each starter job when multiple batches are needed - Enhanced error handling to track successful job creation - Improved logging to show batch information and provide a summary when multiple jobs are created
|
|
Collaborator
|
Hi @omriKaltura, I believe this problem first came up in this issue: But I personally think we should solve this by removing starter pod instead of creating multiple starter pods. Btw, multiple starter pods also add complexity: these pods are no longer synchronized. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When running k6 tests with a large number of hostnames (more than 500 IPs), the starter job fails with a 'Linux argument list too long' error. This is a limitation of the Linux command line length.
Solution
This PR implements a solution to handle large hostname lists by:
maxHostnamesPerBatch = 500to define the maximum number of hostnames per batchTesting
The solution has been tested with more than 500 hostnames and successfully creates multiple starter jobs to handle the large list.