Skip to content

fix(config_wrapper): Honor grpc_listen_address for ring advertisement#22005

Open
rickerc wants to merge 1 commit into
grafana:mainfrom
rickerc:fix/grpc-listen-address-regression
Open

fix(config_wrapper): Honor grpc_listen_address for ring advertisement#22005
rickerc wants to merge 1 commit into
grafana:mainfrom
rickerc:fix/grpc-listen-address-regression

Conversation

@rickerc
Copy link
Copy Markdown

@rickerc rickerc commented May 23, 2026

Internal ring components have no awareness of server.grpc_listen_address. When determining the address to advertise they either use common.instance_addr or auto-detect from network interfaces. This causes gRPC connection failures when gRPC is bound to a specific address like 127.0.0.1 but instance_addr is not also explicitly configured.

Bridge this gap in the config wrapper by propagating grpc_listen_address to instance_addr for ring advertisement when instance_addr is not set.

Closes #7586

What this PR does / why we need it:
server.grpc_listen_address isn't being honored by internal ring components when common.instance_addr is not also specified

Which issue(s) this PR fixes:
Fixes #7586

Special notes for your reviewer:

This makes the configuration of, for example,

server:
http_listen_address: 127.0.0.1
grpc_listen_address: 127.0.0.1

for the use case of binding localhost only work as expected. I didn't figure it's a documentation / configuration change since it's really just making the existing config parameters work as expected...

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@rickerc rickerc requested a review from a team as a code owner May 23, 2026 20:35
@cla-assistant
Copy link
Copy Markdown

cla-assistant Bot commented May 23, 2026

CLA assistant check
All committers have signed the CLA.

@cla-assistant
Copy link
Copy Markdown

cla-assistant Bot commented May 23, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Internal ring components have no awareness of server.grpc_listen_address.
When determining the address to advertise they either use
common.instance_addr or auto-detect from network interfaces. This causes
gRPC connection failures when gRPC is bound to a specific address like
127.0.0.1 but instance_addr is not also explicitly configured.

Bridge this gap in the config wrapper by propagating grpc_listen_address
to instance_addr for ring advertisement when instance_addr is not set.

Closes grafana#7586
@rickerc rickerc force-pushed the fix/grpc-listen-address-regression branch from 5c47ae5 to 92f0921 Compare May 28, 2026 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

grpc_listen_address partially ignored: regression since 2.5.0

1 participant