fix(config_wrapper): Honor grpc_listen_address for ring advertisement#22005
Open
rickerc wants to merge 1 commit into
Open
fix(config_wrapper): Honor grpc_listen_address for ring advertisement#22005rickerc wants to merge 1 commit into
rickerc wants to merge 1 commit into
Conversation
|
|
Internal ring components have no awareness of server.grpc_listen_address. When determining the address to advertise they either use common.instance_addr or auto-detect from network interfaces. This causes gRPC connection failures when gRPC is bound to a specific address like 127.0.0.1 but instance_addr is not also explicitly configured. Bridge this gap in the config wrapper by propagating grpc_listen_address to instance_addr for ring advertisement when instance_addr is not set. Closes grafana#7586
5c47ae5 to
92f0921
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal ring components have no awareness of server.grpc_listen_address. When determining the address to advertise they either use common.instance_addr or auto-detect from network interfaces. This causes gRPC connection failures when gRPC is bound to a specific address like 127.0.0.1 but instance_addr is not also explicitly configured.
Bridge this gap in the config wrapper by propagating grpc_listen_address to instance_addr for ring advertisement when instance_addr is not set.
Closes #7586
What this PR does / why we need it:
server.grpc_listen_address isn't being honored by internal ring components when common.instance_addr is not also specified
Which issue(s) this PR fixes:
Fixes #7586
Special notes for your reviewer:
This makes the configuration of, for example,
server:
http_listen_address: 127.0.0.1
grpc_listen_address: 127.0.0.1
for the use case of binding localhost only work as expected. I didn't figure it's a documentation / configuration change since it's really just making the existing config parameters work as expected...
Checklist
CONTRIBUTING.mdguide (required)docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR