Skip to content

Commit e1a891f

Browse files
authored
chore: fix release-please paths for ci-cd-workflows component (#687)
1 parent 90b0bb2 commit e1a891f

4 files changed

Lines changed: 18 additions & 6 deletions

File tree

.github/prompts/review-code.prompt.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,9 @@ If a new workflow file is added that's part of `ci.yml`/`cd.yml` (like `playwrig
121121

122122
### New User-Facing Actions
123123

124-
If an action is added to `actions/plugins/`, verify `release-please-config.json` is updated.
124+
If an action is added to `actions/plugins/`, verify `release-please-config.json` is updated in two places:
125+
1. A new package entry under `packages` with its `package-name`.
126+
2. The package path added to the `.` package's `exclude-paths` list (otherwise commits in the new plugin double-count toward the `ci-cd-workflows` release).
125127

126128
### Examples Directory
127129

@@ -173,7 +175,7 @@ For every PR, verify:
173175
- [ ] No `ubuntu-latest` — using self-hosted runner labels
174176
- [ ] Same-repo references use `@main`
175177
- [ ] New shared workflows added to switch-references in all 3 files
176-
- [ ] New `actions/plugins/` actions added to `release-please-config.json`
178+
- [ ] New `actions/plugins/` actions added to `release-please-config.json` (both as a new package entry AND in the `.` package's `exclude-paths`)
177179
- [ ] `make genreadme` run if `examples/base/` modified
178180
- [ ] `make mockdata` run if `tests/simple-*` modified
179181
- [ ] Go errors wrapped with context

.release-please-manifest.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"actions/plugins/publish/publish": "2.0.1",
3-
".github/workflows": "7.2.0",
3+
".": "7.2.0",
44
"actions/plugins/version-bump-changelog": "1.1.0",
55
"actions/plugins/publish/change-plugin-scope": "1.0.0",
66
"actions/plugins/release-please": "1.0.1",

AGENTS.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,9 @@ When adding a new shared workflow (internal to ci/cd), add its path to the `swit
136136
- `.github/workflows/release-please-pr-update-tagged-references.yml`
137137
- `.github/workflows/release-please-restore-rolling-release.yml`
138138

139-
When adding a new user-facing action in `actions/plugins/`, update `release-please-config.json`.
139+
When adding a new user-facing action in `actions/plugins/`, update `release-please-config.json`:
140+
1. Add the new package entry under `packages` (with its `package-name`).
141+
2. Add the package path to the `.` package's `exclude-paths` list. This prevents commits in the new plugin from double-counting toward the `ci-cd-workflows` release.
140142

141143
## Testing Framework
142144

release-please-config.json

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,16 @@
6464
"actions/plugins/frontend-e2e-against-stack": {
6565
"package-name": "plugins-frontend-e2e-against-stack"
6666
},
67-
".github/workflows": {
68-
"package-name": "ci-cd-workflows"
67+
".": {
68+
"package-name": "ci-cd-workflows",
69+
"changelog-path": ".github/workflows/CHANGELOG.md",
70+
"exclude-paths": [
71+
"actions/plugins/publish/publish",
72+
"actions/plugins/version-bump-changelog",
73+
"actions/plugins/publish/change-plugin-scope",
74+
"actions/plugins/release-please",
75+
"actions/plugins/frontend-e2e-against-stack"
76+
]
6977
}
7078
},
7179
"release-type": "simple",

0 commit comments

Comments
 (0)