Skip to content

ci: use scoped package names for release-please tags#2700

Merged
jackw merged 1 commit into
mainfrom
jackw/fix-release-please-config
Jun 8, 2026
Merged

ci: use scoped package names for release-please tags#2700
jackw merged 1 commit into
mainfrom
jackw/fix-release-please-config

Conversation

@jackw

@jackw jackw commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:

The first release-please run after the migration (#2689) opened release PR #2699 with two problems:

  1. Broken tag continuity. release-please's node strategy strips the npm scope when deriving the git tag component (@grafana/create-plugincreate-plugin), so it proposed tags like create-plugin@7.8.0 instead of the historical @grafana/create-plugin@7.8.0 format used by every existing tag.
  2. Bloated changelogs. Because the expected tag (create-plugin@7.7.0) doesn't exist — the real tag is @grafana/create-plugin@7.7.0 — release-please couldn't locate the prior release and scanned from the start of history, listing hundreds of already-released commits.

Setting an explicit component (the full scoped name) per package bypasses the scope-stripping normalization. Confirmed against release-please/src/strategies/base.ts:136options.component is used verbatim; normalization only runs on the derived fallback.

Result: tags return to @grafana/<pkg>@<version>, and release-please finds the existing prior tags → scans only new commits → clean changelogs.

Which issue(s) this PR fixes:

related: #2685
related: https://github.com/grafana/grafana-catalog-team/issues/943

Special notes for your reviewer:

  • package-name is kept (npm identity, drives the node-workspace dependency-graph matching); component is the new addition (git tag identity). They default from the same source but component's default normalization strips the scope — hence the explicit override.
  • Verify-before-publish: once this merges, the Release workflow re-runs and updates the open release PR chore: release main #2699 in place. Confirm its compare links read @grafana/<pkg>@<old>...@grafana/<pkg>@<new> and the changelogs are short before merging chore: release main #2699 to trigger the real staged publish.

🤖 Generated with Claude Code

release-please's node strategy strips the npm scope when deriving the
tag component (@grafana/create-plugin -> create-plugin), which broke
tag continuity with the existing @grafana/<pkg>@<version> tags and
caused release-please to scan from the start of history (bloated
changelogs) because it couldn't find the prior tag.

Setting an explicit component per package bypasses the scope-stripping
normalization, restoring the @grafana/<pkg>@<version> tag format.
@jackw jackw requested review from a team as code owners June 8, 2026 12:47
@jackw jackw requested review from Ukochka, mckn and sunker June 8, 2026 12:47
@jackw jackw requested review from ashharrison90 and joshhunt June 8, 2026 12:47
@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

❌ This PR cannot be merged until the following issues are addressed:

  • This PR is missing one of the following labels: patch, minor, major, no-changelog.
  • Optionally if using a patch, minor or major label also add the release label if you would like this PR to trigger npm package publishing.
🏷️ More info about which labels to use
  • If the changes only affect the docs website, documentation, or this repository's tooling add the no-changelog label.
  • If there are changes to any of the npm packages src files please choose from one of the following labels:
    • 🐛 if this PR fixes a bug add the patch label
    • 🚀 if this PR includes an enhancement add the minor label
    • 💥 if this PR includes a breaking change add the major label
  • Optionally, if you would like this PR to publish new versions of packages when it is merged add the release label.

@jackw jackw changed the title fix: use scoped package names for release-please tags ci: use scoped package names for release-please tags Jun 8, 2026
@jackw jackw moved this from 📬 Triage to 🔬 In review in Grafana Catalog Team Jun 8, 2026
@jackw jackw moved this to 🔍 In review in Grafana Frontend Platform Jun 8, 2026
@jackw jackw self-assigned this Jun 8, 2026

@ashharrison90 ashharrison90 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 👍

@jackw jackw merged commit cd787cc into main Jun 8, 2026
34 of 35 checks passed
@jackw jackw deleted the jackw/fix-release-please-config branch June 8, 2026 12:57
@github-project-automation github-project-automation Bot moved this from 🔍 In review to 🚀 Done in Grafana Frontend Platform Jun 8, 2026
@github-project-automation github-project-automation Bot moved this from 🔬 In review to 🚀 Shipped in Grafana Catalog Team Jun 8, 2026
@jackw jackw mentioned this pull request Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project
Status: 🚀 Done

Development

Successfully merging this pull request may close these issues.

3 participants