chore(deps): update github.com/grafana/dskit to de42b217b3c1#5098
Closed
bubu11e wants to merge 5 commits into
Closed
chore(deps): update github.com/grafana/dskit to de42b217b3c1#5098bubu11e wants to merge 5 commits into
bubu11e wants to merge 5 commits into
Conversation
|
|
|
|
Bump dskit to pick up: - fix(tracing): respect OTEL_TRACES_SAMPLER env var in NewOTelFromEnv (grafana/dskit#944) The tracing change ensures NewOTelFromEnv honors the standard OTEL_TRACES_SAMPLER and OTEL_TRACES_SAMPLER_ARG environment variables, including support for Jaeger remote samplers. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
bubu11e
force-pushed
the
fix/otel-sampler-from-env
branch
from
2c6491c to
0079939
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump dskit to pick up:
The tracing change ensures NewOTelFromEnv honors the standard OTEL_TRACES_SAMPLER and OTEL_TRACES_SAMPLER_ARG environment variables, including support for Jaeger remote samplers.
Note
Low Risk
Low risk dependency/tooling bump; primary risk is behavior changes introduced by updated
github.com/grafana/dskitand tracing/otel-related transitive updates.Overview
Updates the project’s Go version from
1.25.7to1.25.8in bothgo.modandgo.work.Bumps
github.com/grafana/dskittode42b217b3c1and refreshesgo.sum, pulling in newer transitive versions for Consul (github.com/hashicorp/consul/api), etcd client libs, Prometheusprocfs, and several OpenTelemetry contrib/exporter packages.Reviewed by Cursor Bugbot for commit 7d8ed17. Bugbot is set up for automated code reviews on this repo. Configure here.