fix: avoid TS2742 in generated client under pnpm isolated node_modules#1496
Open
PBRT wants to merge 1 commit into
Open
fix: avoid TS2742 in generated client under pnpm isolated node_modules#1496PBRT wants to merge 1 commit into
PBRT wants to merge 1 commit into
Conversation
The generated `create` function had an inferred return type that transitively referenced `@wollybeard/kit` internals through subpath barrels TypeScript could not portably name when emitting declarations under pnpm's isolated node_modules layout, producing TS2742 errors in consumer projects. - Export the `Create` type from the main client entry so the generator can refer to it by a portable name. - Make the generator emit a type-only import of `Create` and annotate the generated `create` with `Create<typeof context>`, giving the emitted declaration a nameable return type. - Expose the `build/*` subpaths referenced by the generated declaration via `package.json` `exports` so consumers can actually resolve them. Refs graffle-js#1484
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generated
createfunction had an inferred return type that transitively referenced@wollybeard/kitinternals through subpath barrels TypeScript could not portably name when emitting declarations under pnpm's isolated node_modules layout, producing TS2742 errors in consumer projects.Createtype from the main client entry so the generator can refer to it by a portable name.Createand annotate the generatedcreatewithCreate<typeof context>, giving the emitted declaration a nameable return type.build/*subpaths referenced by the generated declaration viapackage.jsonexportsso consumers can actually resolve them.Refs #1484