Skip to content

Commit 2c9a13a

Browse files
authored
Merge pull request #9 from gragra33/hotfix/copilot-pr7-fixes
fix: address Copilot PR #7 review feedback
2 parents 9bd1c7d + 01a1c62 commit 2c9a13a

2 files changed

Lines changed: 12 additions & 2 deletions

File tree

.github/workflows/release.yml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,10 @@ on:
55
branches:
66
- master
77

8+
concurrency:
9+
group: ${{ github.workflow }}-${{ github.ref }}
10+
cancel-in-progress: false
11+
812
jobs:
913
release:
1014
name: Build, Test & Publish to NuGet
@@ -53,6 +57,12 @@ jobs:
5357
echo "exists=false" >> $GITHUB_OUTPUT
5458
fi
5559
60+
- name: Fail if this version was already released
61+
if: steps.tag_check.outputs.exists == 'true'
62+
run: |
63+
echo "::error::Release tag ${{ steps.version.outputs.tag }} already exists. Bump the project version before pushing to master."
64+
exit 1
65+
5666
- name: Pack NuGet package
5767
if: steps.tag_check.outputs.exists == 'false'
5868
run: |

tests/Blazing.Json.Queryable.Tests/CollectionDefinitions.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,12 @@ namespace Blazing.Json.Queryable.Tests;
77
/// </summary>
88
/// <remarks>
99
/// <para>
10-
/// <see cref="DisableParallelization"/> is set to <see langword="true"/> so that when any
10+
/// <see cref="Xunit.CollectionDefinitionAttribute.DisableParallelization"/> is set to <see langword="true"/> so that when any
1111
/// test in this collection executes, no other test collection runs concurrently.
1212
/// </para>
1313
/// <para>
1414
/// This is required because <see cref="Blazing.Json.Queryable.Implementations.SpanPropertyAccessor"/>
15-
/// uses a process-wide static <see cref="System.Collections.Concurrent.ConcurrentDictionary{TKey, TValue}"/>
15+
/// uses a process-wide static <see cref="System.Collections.Concurrent.ConcurrentDictionary{TKey,TValue}"/>
1616
/// cache. Tests in this collection call <c>ClearCache()</c> and assert on <c>CacheCount</c> —
1717
/// assertions that are only valid when no other test is concurrently populating the cache.
1818
/// </para>

0 commit comments

Comments
 (0)