PersonRelationshipFilter (gramps51 port)#989
Open
dsblank wants to merge 1 commit into
Open
Conversation
Gramplet providing a Person sidebar filter on relationships (father, mother, spouse, siblings, children) with regex/substring name matching and a "probably alive" date filter. Ports the addon (originally by Nick Hall and Paul Womack/BugBear) to the 5.1 API, guards Filter.__filter_clicked against re-entrant build_tree() calls, and points help_url at this addon's own wiki page. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Member
Author
|
@GaryGriffin I have no idea why this addon might have an issue with Macs. But I did make a change here. |
Member
|
Uploaded change but it still intermittently crashes on 5.1.6 . I thought to file a bug with a crash report, but Mantis only goes back to 5.2.0, not 5.1.6 . |
Member
|
@dsblank Do you want me to hold this until the Mac crash is resolved? I suspect it is a core issue with a system library, which will not be fixed (would require a new bundle). Or do you want me to publish with the known caveat it is unstable on Mac on 5.1 and the fix is to upgrade to at least 5.2? Can you add the wiki help page as it is blank. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Filter.__filter_clickedagainst re-entrantbuild_tree()calls (a suspected cause of an intermittent, non-reproducible segfault reported by a user running the 5.1 build).help_urlto point at this addon's own wiki page (Addon:PersonRelationshipFilter) instead of a leftover reference to a different addon name.Companion ports: #987 (6.1), #988 (5.2).
Test plan
pytest PersonRelationshipFilter/tests/passes