PersonRelationshipFilter (gramps51 port) - #989
Conversation
Gramplet providing a Person sidebar filter on relationships (father, mother, spouse, siblings, children) with regex/substring name matching and a "probably alive" date filter. Ports the addon (originally by Nick Hall and Paul Womack/BugBear) to the 5.1 API, guards Filter.__filter_clicked against re-entrant build_tree() calls, and points help_url at this addon's own wiki page. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
@GaryGriffin I have no idea why this addon might have an issue with Macs. But I did make a change here. |
|
Uploaded change but it still intermittently crashes on 5.1.6 . I thought to file a bug with a crash report, but Mantis only goes back to 5.2.0, not 5.1.6 . |
|
@dsblank Do you want me to hold this until the Mac crash is resolved? I suspect it is a core issue with a system library, which will not be fixed (would require a new bundle). Or do you want me to publish with the known caveat it is unstable on Mac on 5.1 and the fix is to upgrade to at least 5.2? Can you add the wiki help page as it is blank. |
|
@emyoulation do you have an opinion on:
|
|
I suspect that sharing it now as a separate 5.1 "experimental status" addon will be the most effective approach. That will allow a broader cross-section of users to experiment and comment. But segregating it from the 5.2+ version will decouple any bloat from that might not be necessary with the other versions. (I suspect that the macOS 5.1 install bundle might have skipped some libraries. It might be necessary to bundle those in the 5.1 addon.) And it will allow native macOS users to experiment with Claude (or their favorite AI of the moment) interactively to troubleshoot or to add diagnostics. |
Not really possible to overwrite in the addon a portion of core functionality. When I have seen this type of crash on Mac, it is often due to gtk or cairo bugs. System core (crash) file indicates this is likely the area of issue, but I am not skilled in diagnosing this. There was nothing 'skipped' in the Mac 5.1 bundle (This is what I use for my production system).
I suspect that the intersection of (Mac User | Gramps 5.1 User | AI User) is the NULL set. IMO, the response is to have them upgrade to at least 5.2 if they want this functionality. My suggestion is to add a known issue to the Wiki Help page for the addon and I can merge/publish it on 5.1 too. I want to avoid bug reports since this is a hard crash of gramps. |
|
@GaryGriffin IMHO you can close this. |
|
Closing PR. The README specifically states the min branch is 5.2 . |
3 participants
Summary
Filter.__filter_clickedagainst re-entrantbuild_tree()calls (a suspected cause of an intermittent, non-reproducible segfault reported by a user running the 5.1 build).help_urlto point at this addon's own wiki page (Addon:PersonRelationshipFilter) instead of a leftover reference to a different addon name.Companion ports: #987 (6.1), #988 (5.2).
Test plan
pytest PersonRelationshipFilter/tests/passes