impl: added change-feed reConnection mechanism#92
Open
KrishnaPG wants to merge 2 commits intograntcarthew:masterfrom
Open
impl: added change-feed reConnection mechanism#92KrishnaPG wants to merge 2 commits intograntcarthew:masterfrom
KrishnaPG wants to merge 2 commits intograntcarthew:masterfrom
Conversation
Owner
|
Hi @KrishnaPG. Sorry for the late reply. This went under my radar for some reason. I can't see any unit tests added for this change. It looks great otherwise. Can you add a unit test or two? |
Owner
|
On a side note @KrishnaPG, are you interested in becoming a maintainer? Are you a JavaScript ninja? Your profile indicates some level of skill. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables change-feed reconnection when the connection drops.
reconnectoptions have been added that expose thepingIntervalas well as connection reattempt controlsNote that this reconnection is only limited to the
change feedsand other parts of the package, such as dbAssertion etc. still may fail on connection failure.