Skip to content

Commit a5c6e1f

Browse files
committed
Report empty instead of external entity system id
1 parent a11dd18 commit a5c6e1f

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

lib/XML/Simple.pm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -454,7 +454,7 @@ sub new_xml_parser {
454454
my($self) = @_;
455455

456456
my $xp = XML::Parser->new(Style => 'Tree', @{$self->{opt}->{parseropts}});
457-
$xp->setHandlers(ExternEnt => sub {return $_[2]});
457+
$xp->setHandlers(ExternEnt => sub {return ''});
458458

459459
return $xp;
460460
}

t/C_External_Entities.t

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ my $xml = qq(<?xml version="1.0"?>
2929

3030
my $opt = XMLin($xml);
3131
isnt($opt->{'user'}, 'bad', 'External entity not retrieved');
32-
like($opt->{'user'}, qr/^file/, 'External entity left as URL');
32+
is_deeply($opt->{'user'}, {}, 'External entity left as empty');
3333

3434
unlink($filename) if (-f $filename);
3535
exit(0);

0 commit comments

Comments
 (0)