Add performance tests#129
Open
akrzgc wants to merge 17 commits into
Open
Conversation
hatemhelal
reviewed
Oct 23, 2023
Contributor
hatemhelal
left a comment
There was a problem hiding this comment.
An idea to capture the cycle count measurement would be to make it a function decorator. That way we could reuse it outside of nanoDFT as I imagine it would be useful to define micro-benchmarks. I have a preference to break things down into smaller PRs but lets discuss.
Comment on lines
+3
to
+5
| filterwarnings = | ||
| error | ||
| ignore::DeprecationWarning |
Contributor
There was a problem hiding this comment.
I wasn't familiar with these options, looks useful!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch is adding performance tests for
nanoDFT.So far it is possible to just execute initial 5 tests with simple purest command
purest tests/test_benchmark_performance.py.The code injecting the
ipu_cycle_countinto the_nanoDFT()jitted method is WIP.The branch is going to:
nanoDFT()performance evaluation withipu_cycle_countpytestfor performance testingipu_cycle_countcode and move it toutils