You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
nanoDFT.py appeared to be broken when supplying a custom mol_str because min_interatomic_distance() expects a list.
Also, I added a warning when the computed minimum interatomic distance is out of a "sane" range, assuming Angstrom as length unit.
It may be useful to note that the coordinates in the conformers in PubChem can be expressed in different units.
The information regarding the units is conveyed in fields present in the SDF, JSON, or XML record.
In SDF, according to the specs, the relevant field is as follows:
This is problematic because, for instance, in the case of cyclodextrin, the coordinates provided by PubChem are in unknown units (shown as 255).
Also, the package pubchempy does not seem to make the PUBCHEM_COORDINATE_TYPE information accessible. The repo for package seems to be dormant. The most recent update was 6 years ago.
If we want to get the units, we might have to brew our own code, parsing the JSON obtained by urls such as: https://pubchem.ncbi.nlm.nih.gov/rest/pug/compound/name/esomeprazole/JSON?record_type=3d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nanoDFT.py appeared to be broken when supplying a custom
mol_strbecause min_interatomic_distance() expects a list.Also, I added a warning when the computed minimum interatomic distance is out of a "sane" range, assuming Angstrom as length unit.