Skip to content

Compile and run will both replace includes now.#248

Merged
benjie merged 10 commits intographile:mainfrom
sporieg-qi:main
Apr 22, 2026
Merged

Compile and run will both replace includes now.#248
benjie merged 10 commits intographile:mainfrom
sporieg-qi:main

Conversation

@sporieg-qi
Copy link
Copy Markdown
Contributor

@sporieg-qi sporieg-qi commented Feb 11, 2026

Description

There was already a PR for this, #235, but rather than go two steps removed to get this across the finish line I just forked the up to date repo and made sure to add tests, address the feedback I saw on the other PR.

Performance impact

Security impact

Checklist

  • My code matches the project's code style and yarn lint:fix passes.
  • I've added tests for the new feature, and yarn test passes.
  • I have detailed the new feature in the relevant documentation.
  • I have added this feature to 'Pending' in the RELEASE_NOTES.md file (if one exists).
  • If this is a breaking change I've explained why.

@sporieg-qi sporieg-qi changed the title Compile and run will both replace placeholders now. Compile and run will both replace includes now. Feb 11, 2026
@zarybnicky
Copy link
Copy Markdown

@benjie Can you take a look? It seems to look good, IMO. (I hadn't managed to finish my original PR.)

@benjie
Copy link
Copy Markdown
Member

benjie commented Apr 11, 2026

Yeah I'm a bit behind at the moment but it is in my queue 👍

@aviallon
Copy link
Copy Markdown

@benjie thank you very much!

Copy link
Copy Markdown
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent; thanks for your work on this! I've refactored it a bit and made the change to the compile export non-breaking (even though technically it's not a supported interface, there may be people using it).

@benjie benjie merged commit b9b85ec into graphile:main Apr 22, 2026
7 checks passed
@aviallon
Copy link
Copy Markdown

Excellent; thanks for your work on this! I've refactored it a bit and made the change to the compile export non-breaking (even though technically it's not a supported interface, there may be people using it).

I use it myself in my data-layer tests. It allows testing against the current.sql easily, without having to commit a migration.

@benjie
Copy link
Copy Markdown
Member

benjie commented Apr 22, 2026

Released in graphile-migrate@2.0.0-rc.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: compile and run should be able to --!include fixtures

4 participants