Skip to content

Commit f00b854

Browse files
authored
Make LogLevel verbatim syntax safe (breaking) (#605)
2 parents 6432130 + 2c285d4 commit f00b854

5 files changed

Lines changed: 15 additions & 11 deletions

File tree

RELEASE_NOTES.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@ Read more:
2828
reach the end of the scope. (Primarily useful for tests.)
2929
- Maintenance work: upgrade to latest TypeScript, Jest, eliminate ts-node, fix
3030
yargs, use erasable syntax only for type-stripping support,
31+
- `LogLevel` export is now type only - a string union rather than a TypeScript
32+
const enum.
3133

3234
## v0.17.2
3335

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@
4949
},
5050
"homepage": "https://github.com/graphile/worker#readme",
5151
"dependencies": {
52-
"@graphile/logger": "^0.2.0",
52+
"@graphile/logger": "^0.3.0",
5353
"@types/debug": "^4.1.10",
5454
"@types/pg": "^8.10.5",
5555
"cosmiconfig": "^8.3.6",

src/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@ import type {
2323
import type { CompiledSharedOptions } from "./lib.ts";
2424
export { parseCronItem, parseCronItems, parseCrontab } from "./crontab.ts";
2525
export * from "./interfaces.ts";
26-
export type { LogFunctionFactory } from "./logger.ts";
27-
export { consoleLogFactory, Logger, LogLevel } from "./logger.ts";
26+
export type { LogFunctionFactory, LogLevel } from "./logger.ts";
27+
export { consoleLogFactory, Logger } from "./logger.ts";
2828
export { runTaskList, runTaskListOnce } from "./main.ts";
2929
export { WorkerPreset } from "./preset.ts";
3030
export { run, runMigrations, runOnce } from "./runner.ts";

src/logger.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,12 @@ if (process.env.GRAPHILE_WORKER_DEBUG) {
33
process.env.GRAPHILE_LOGGER_DEBUG = process.env.GRAPHILE_WORKER_DEBUG;
44
}
55

6-
import type { LogFunctionFactory as GraphileLogFunctionFactory } from "@graphile/logger";
6+
import type {
7+
LogFunctionFactory as GraphileLogFunctionFactory,
8+
LogLevel,
9+
} from "@graphile/logger";
710
import {
811
Logger as GraphileLogger,
9-
LogLevel,
1012
makeConsoleLogFactory,
1113
} from "@graphile/logger";
1214

@@ -17,7 +19,7 @@ export interface LogScope {
1719
jobId?: string;
1820
}
1921

20-
export { LogLevel };
22+
export type { LogLevel };
2123

2224
// For backwards compatibility
2325
export class Logger extends GraphileLogger<LogScope> {}

yarn.lock

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2450,10 +2450,10 @@ __metadata:
24502450
languageName: node
24512451
linkType: hard
24522452

2453-
"@graphile/logger@npm:^0.2.0":
2454-
version: 0.2.0
2455-
resolution: "@graphile/logger@npm:0.2.0"
2456-
checksum: 10/0b080871c8c3698371ae5ce9633597ff636cf8be1227cf640c1effb70e2fa4d7aa7fb90e72da3f990076951a38511a2b6ab82c276a791644bec164966a38d000
2453+
"@graphile/logger@npm:^0.3.0":
2454+
version: 0.3.0
2455+
resolution: "@graphile/logger@npm:0.3.0"
2456+
checksum: 10/2eff71dcc68eaf37fea241c6122219bd03c490688aab160f89db46c478dd86ea7e7165ce49c1a510587a785a2774825d9396b6a277ab860c4889e9e25e5beee7
24572457
languageName: node
24582458
linkType: hard
24592459

@@ -8013,7 +8013,7 @@ __metadata:
80138013
"@fortawesome/free-regular-svg-icons": "npm:^6.5.1"
80148014
"@fortawesome/free-solid-svg-icons": "npm:^6.5.1"
80158015
"@fortawesome/react-fontawesome": "npm:^0.2.0"
8016-
"@graphile/logger": "npm:^0.2.0"
8016+
"@graphile/logger": "npm:^0.3.0"
80178017
"@jest/globals": "npm:^30.2.0"
80188018
"@mdx-js/react": "npm:^1.6.22"
80198019
"@tsconfig/node-ts": "npm:^23.6.4"

0 commit comments

Comments
 (0)