Commit ca2b45e
fix(gfql): gate DAG NIE pass-through to polars; skip polars conformance without polars
Two CI failures on this layer, both diagnosed from the failing 3.8/3.14 jobs:
(A, real regression) execute_call() added an unconditional
'if isinstance(error, NotImplementedError): raise error' to propagate the polars
no-silent-bridge decline on the DAG surface — but it ALSO intercepted a
pandas/cudf NIE like fa2_layout's 'requires a GPU', so it stopped falling through
to the GFQLTypeError(E303) wrapper and test_fa2_layout_cpu_requires_gpu failed.
Gate the pass-through to engine in (POLARS, POLARS_GPU); pandas/cudf NIEs wrap to
E303 as before. Verified: fa2 test passes, full test_call_operations green (24/2).
(B, py3.14 env) test_engine_polars_conformance_matrix hardcodes the polars lane
without probing importability; on Python 3.14 (no cp314 polars wheel) polars is
absent from the lockfile, so every case reported a non-NIE ImportError as a
conformance failure (~60). Add module-level pytest.importorskip('polars') so the
matrix skips cleanly when polars is unavailable.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent 1609331 commit ca2b45e
2 files changed
Lines changed: 8 additions & 1 deletion
File tree
- graphistry
- compute/gfql/call
- tests/compute/gfql
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
253 | 253 | | |
254 | 254 | | |
255 | 255 | | |
256 | | - | |
| 256 | + | |
257 | 257 | | |
258 | 258 | | |
| 259 | + | |
| 260 | + | |
259 | 261 | | |
260 | 262 | | |
261 | 263 | | |
| |||
Lines changed: 5 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
18 | 23 | | |
19 | 24 | | |
20 | 25 | | |
| |||
0 commit comments