Skip to content

Commit f997217

Browse files
lmeyerovclaude
andcommitted
ci(gfql/polars): run cypher test_lowering polars cases in the polars lane
The polars-parametrized cypher tests (numeric fns, toLower, =~ parity in graphistry/tests/compute/gfql/cypher/test_lowering.py) never executed in CI: the core lane has no polars installed (importorskip -> skip) and the polars lane's fixed file list excluded the file. So the polars numeric lowerings this branch adds were CI-untested and their changed lines uncovered (coverage gate 76.9% < 80). Add the file (-k polars) to bin/test-polars.sh and the ci.yml polars coverage step (--cov-append). Moved from the stacked #1677 to here — it belongs with the lowerings it tests. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 26c977a commit f997217

2 files changed

Lines changed: 7 additions & 0 deletions

File tree

.github/workflows/ci.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1413,6 +1413,9 @@ jobs:
14131413
graphistry/tests/compute/gfql/test_engine_polars_chain.py \
14141414
graphistry/tests/compute/gfql/test_engine_polars_row_pipeline.py \
14151415
graphistry/tests/compute/gfql/test_engine_polars_cypher_conformance.py
1416+
COVERAGE_FILE=build/polars-coverage/coverage.polars-py3.12 python -B -m pytest -vv \
1417+
--cov=graphistry/compute --cov-report= --cov-append \
1418+
graphistry/tests/compute/gfql/cypher/test_lowering.py -k polars
14161419
14171420
- name: Upload polars coverage
14181421
if: ${{ matrix.python-version == '3.12' }}

bin/test-polars.sh

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,3 +15,7 @@ python -B -m pytest -vv \
1515
graphistry/tests/compute/gfql/test_engine_polars_chain.py \
1616
graphistry/tests/compute/gfql/test_engine_polars_row_pipeline.py \
1717
graphistry/tests/compute/gfql/test_engine_polars_cypher_conformance.py
18+
19+
# cypher-lowering polars-parametrized cases (round ties, lower/upper, =~, numeric fns)
20+
python -B -m pytest -vv \
21+
graphistry/tests/compute/gfql/cypher/test_lowering.py -k polars

0 commit comments

Comments
 (0)