feat(cypher): OR/XOR-around-pattern WHERE lowering (#1236)#1244
Merged
feat(cypher): OR/XOR-around-pattern WHERE lowering (#1236)#1244
Conversation
42e5849 to
4c80fd5
Compare
This was referenced May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements
#1236(parent#1031slice 4): support booleanOR/XORcompositions around CypherWHEREpattern predicates in local lowering/runtime.What changed
semi_apply_mark(...)for correlated pattern-existence marker columns.semi_apply_mark.expr_treefor OR/XOR contexts instead of fail-fast rejection.semi_apply_mark(safelist/schema-effects + runtime behavior), in addition to parser/lowering OR/XOR regressions.CHANGELOG.md([Development]/Internal).Files
graphistry/compute/ast.pygraphistry/compute/gfql/call/validation.pygraphistry/compute/gfql/row/pipeline.pygraphistry/compute/gfql/cypher/parser.pygraphistry/compute/gfql/cypher/_boolean_expr_text.pygraphistry/compute/gfql/cypher/lowering.pygraphistry/tests/compute/gfql/cypher/test_parser.pygraphistry/tests/compute/gfql/cypher/test_lowering.pygraphistry/tests/compute/gfql/test_row_pipeline_ops.pyCHANGELOG.mdValidation
Local
PYTHONDONTWRITEBYTECODE=1 PYTHONPATH=. uv run --no-project --with lark pytest -q graphistry/tests/compute/gfql/test_row_pipeline_ops.py -k "semi_apply_mark"3 passedPYTHONDONTWRITEBYTECODE=1 PYTHONPATH=. uv run --no-project --with lark pytest -q graphistry/tests/compute/gfql/cypher/test_parser.py graphistry/tests/compute/gfql/cypher/test_lowering.py -k "executes_or_xor_around_pattern_predicates or where_pattern_predicate_and_expr_mix"17 passeduv run ruff check graphistry/tests/compute/gfql/test_row_pipeline_ops.pyAll checks passedDGX RAPIDS matrix (
ssh dgx-spark)Targeted cuDF/GFQL subset:
test_graph_constructor_cudf_supporttest_string_cypher_formats_filtered_edge_entity_projection_on_cudftest_string_cypher_executes_real_cugraph_node_row_call_on_cudftest_string_cypher_executes_or_xor_around_pattern_predicatesResults:
25.02+NUMBA_CUDA_USE_NVIDIA_BINDING=1:6 passed26.02:6 passedNote:
25.02without the env workaround can hit a known numba-cuda driver-path crash (numba.cuda.current_context()/ cuDFto_pandas()path). This is environment/runtime behavior observed on both branch andmaster, not a gfql/cypher: OR/XOR-around-pattern lowering via Apply/SemiApply runtime (#1031 slice 4) #1236 branch regression.CI
gh pr checks 1244: all checks passing, including bothtck-gfqlruns.Closes #1236
Refs #1031