Skip to content

Commit 4c1c021

Browse files
committed
fix: specify primary key in risingwave test for duplicate columns
1 parent 4100175 commit 4c1c021

1 file changed

Lines changed: 7 additions & 3 deletions

File tree

db_proto/sql/risingwave/dialect_test.go

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ func TestDialectRisingwave_CreateTable_ChildTable(t *testing.T) {
196196
require.NoError(t, err)
197197

198198
sql := d.CreateTableSql["mints"]
199-
assert.Contains(t, sql, "CREATE TABLE IF NOT EXISTS public.mints")
199+
assert.Contains(t, sql, "CREATE TABLE IF NOT EXISTS public.mints")
200200
assert.Contains(t, sql, "block_number INTEGER")
201201
assert.Contains(t, sql, "block_timestamp TIMESTAMP WITH TIME ZONE")
202202
assert.Contains(t, sql, "instruction_id CHARACTER VARYING")
@@ -261,6 +261,10 @@ func TestDialectRisingwave_CreateTable_PreventsDuplicateColumns(t *testing.T) {
261261

262262
table := &schema.Table{
263263
Name: "test_table",
264+
PrimaryKey: &schema.PrimaryKey{
265+
Name: "name",
266+
FieldDescriptor: nameField,
267+
},
264268
Columns: []*schema.Column{
265269
{Name: "block_number", FieldDescriptor: idField}, // This should be skipped since block_number is added automatically
266270
{Name: "name", FieldDescriptor: nameField},
@@ -273,7 +277,7 @@ func TestDialectRisingwave_CreateTable_PreventsDuplicateColumns(t *testing.T) {
273277

274278
sql := d.CreateTableSql["test_table"]
275279

276-
// block_number should appear only once
280+
// block_number should appear only once (user-defined duplicate prevented)
277281
assert.Equal(t, 1, strings.Count(sql, "block_number"))
278282
assert.Contains(t, sql, `"name" CHARACTER VARYING`)
279283
}
@@ -582,7 +586,7 @@ func TestDialectRisingwave_ComplexTableStructure(t *testing.T) {
582586
sql := d.CreateTableSql["complex_users"]
583587

584588
// Check all expected elements are present
585-
assert.Contains(t, sql, "CREATE TABLE IF NOT EXISTS public.complex_users")
589+
assert.Contains(t, sql, "CREATE TABLE IF NOT EXISTS public.complex_users")
586590
assert.Contains(t, sql, "id CHARACTER VARYING PRIMARY KEY")
587591
assert.Contains(t, sql, `"name" CHARACTER VARYING`)
588592
assert.Contains(t, sql, `"age" INTEGER`)

0 commit comments

Comments
 (0)